Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show source name with "flux get kustomization" #2692

Open
makkes opened this issue Feb 1, 2022 · 9 comments · May be fixed by fluxcd/kustomize-controller#557
Open

Show source name with "flux get kustomization" #2692

makkes opened this issue Feb 1, 2022 · 9 comments · May be fixed by fluxcd/kustomize-controller#557
Assignees
@ysg410
Labels
area/kustomization Kustomization related issues and pull requests enhancement New feature or request

Comments

@makkes
Copy link
Member

makkes commented Feb 1, 2022 •
edited
Loading

When looking at a cluster with Kustomizations from different sources it would be helpful to print the source's name of each Kustomization when listing them.
@makkes makkes added enhancement New feature or request area/kustomize labels Feb 1, 2022
makkes referenced this issue in fluxcd/kustomize-controller Feb 1, 2022
feat: add sourceRef.name column to Kustomization print columns
454790c 
closes #556

Signed-off-by: Max Jonas Werner <[email protected]>
@makkes makkes linked a pull request Feb 1, 2022 that will close this issue
Open
@stefanprodan
Copy link
Member

I would add the source after NAME

@somtochiama
Copy link
Member

Would it be better to make the source column namspace/name since the source can be in a different namespace?

@makkes
Copy link
Member Author

makkes commented Feb 1, 2022

Would it be better to make the source column namspace/name since the source can be in a different namespace?

I would have loved to do that, plus the source's kind. But unfortunately the JSONPath you can use with the additionalPrinterColumns field is very simplistic so from what I know it's not possible to aggregate the values of multiple fields into one. 😞

@stefanprodan
Copy link
Member

stefanprodan commented Feb 1, 2022 •
edited
Loading

Maybe we should leave this as it is and improve flux get where we can do aggregations.

@makkes
Copy link
Member Author

makkes commented May 2, 2022 •
edited
Loading

How about this?

$ ./bin/flux get ks velero -A --include-source
NAMESPACE       NAME    SOURCE                                  REVISION        SUSPENDED       READY   MESSAGE
kommander       velero  GitRepository/kommander-flux/management main/d8bac31    False           True    Applied revision: main/d8bac31

@makkes makkes transferred this issue from fluxcd/kustomize-controller May 2, 2022
@makkes makkes changed the title Show source name as additional printer column Show source name with "flux get kustomization" May 2, 2022
@makkes makkes added area/kustomization Kustomization related issues and pull requests and removed area/kustomize labels May 2, 2022
@makkes
Copy link
Member Author

makkes commented May 2, 2022

I just realized I should've created a new issue in flux2 but instead transferred the existing one from kustomize-controller, effectively making the discussion hard to reason about. Sorry for that

@ysg410
Copy link

ysg410 commented Aug 31, 2023

Hi @makkes - is this still an open issue?
I'd be happy to contribute.

@stefanprodan
Copy link
Member

I propose we use flux get ks --show-source to follow kubectl conventions.

@ysg410 if you can contribute this feature would be great!

@ysg410
Copy link

ysg410 commented Sep 1, 2023

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ysg410 ysg410

Labels
area/kustomization Kustomization related issues and pull requests enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add sourceRef.name column to Kustomization print columns fluxcd/kustomize-controller
4 participants
@makkes @stefanprodan @ysg410 @somtochiama