Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HCVault: refactor test to avoid using docker #648

Open
souleb opened this issue May 11, 2022 · 1 comment · May be fixed by #658
Open

HCVault: refactor test to avoid using docker #648

souleb opened this issue May 11, 2022 · 1 comment · May be fixed by #658
Labels
area/sops SOPS related issues and pull requests

Comments

@souleb
Copy link
Member

souleb commented May 11, 2022

The test cases in internal/sops/hcvault/keysource_test.go use "github.com/ory/dockertest" to spin up a test vault server.

We want to replace this to avoid having a dependency with docker. Instead we want to use a HVCault test server like https://pkg.go.dev/github.com/hashicorp/vault/vault#TestCluster.
@souleb souleb added the area/sops SOPS related issues and pull requests label May 11, 2022
@somtochiama somtochiama linked a pull request May 23, 2022 that will close this issue
Draft
@cwrau
Copy link

cwrau commented Sep 12, 2024

This would be amazing, testing this is kinda a nightmare; having to install etcd and kube-apiserver and having to pollute our dev environment with temporary directories which may or may not be cleaned up on exit makes it kinda necessary to run them in containers, which IntelliJ thankfully supports, but having to somehow wire some container engine into the container just because some tests need this vault makes it kinda impossible again.

I've resorted to just commenting out

kustomize-controller/internal/controller/suite_test.go

Line 130 in 96a7722

panic(fmt.Sprintf("Failed to create Vault instance: %v", err))
the panic and hoping it works in CI 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/sops SOPS related issues and pull requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor test to use hcvault NewTestCluster somtochiama/kustomize-controller
2 participants
@cwrau @souleb