From cde92a7baec0beb76cdbe1229637574f8c409dbf Mon Sep 17 00:00:00 2001 From: Zhiyu Wang Date: Thu, 31 Aug 2023 09:34:54 +0000 Subject: [PATCH] Chore: use auto bucket lookup type Signed-off-by: Zhiyu Wang --- pkg/minio/minio.go | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/pkg/minio/minio.go b/pkg/minio/minio.go index f1930dbd5..0aceef815 100644 --- a/pkg/minio/minio.go +++ b/pkg/minio/minio.go @@ -38,9 +38,10 @@ type MinioClient struct { // NewClient creates a new Minio storage client. func NewClient(bucket *sourcev1.Bucket, secret *corev1.Secret) (*MinioClient, error) { opt := minio.Options{ - Region: bucket.Spec.Region, - Secure: !bucket.Spec.Insecure, - BucketLookup: minio.BucketLookupPath, + Region: bucket.Spec.Region, + Secure: !bucket.Spec.Insecure, + // About BucketLookup, it should be noted that not all S3 providers support path-type access (e.g., Ali OSS). + // Hence, we revert to using the default auto access, which we believe can cover most use cases. } if secret != nil {