Chore: use auto bucket lookup type

Signed-off-by: Zhiyu Wang <[email protected]>
fluxcd · Aug 31, 2023 · d174bff · d174bff
1 parent 0124126
commit d174bff
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/pkg/minio/minio.go b/pkg/minio/minio.go
@@ -38,9 +38,11 @@ type MinioClient struct {
 // NewClient creates a new Minio storage client.
 func NewClient(bucket *sourcev1.Bucket, secret *corev1.Secret) (*MinioClient, error) {
 	opt := minio.Options{
-		Region:       bucket.Spec.Region,
-		Secure:       !bucket.Spec.Insecure,
-		BucketLookup: minio.BucketLookupPath,
+		Region: bucket.Spec.Region,
+		Secure: !bucket.Spec.Insecure,
+		// About BucketLookup, it should be noted that not all S3 providers support
+		// path-type access (e.g., Ali OSS). Hence, we revert to using the default
+		// auto access, which we believe can cover most use cases.
 	}
 
 	if secret != nil {