Introduce Bucket provider constants with the common part as a prefix #1589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matheus Pimenta <[email protected]>
matheuscscp
force-pushed
the
new-bucket-provider-constants
branch
from
d181710 to
02d492b
Compare
stefanprodan
approved these changes
Aug 23, 2024
darkowlzz
reviewed
Aug 23, 2024
| // GenericBucketProvider for any S3 API compatible storage Bucket. | ||
| // Deprecated: use BucketProviderGeneric. |
There was a problem hiding this comment.
This isn't being shown as deprecated in my IDE with gopls. If a newline is added above this line, it is recognized as deprecated and IDE visually shows it as deprecated by striking through the word.
Looking at https://go.dev/wiki/Deprecated newline seems to be required.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1569