feat(efb): Set default efb auto brightness on

[MrJigs7]

Fixes #9630

Summary of Changes

Updated EFB so auto brightness defaults to on

Screenshots (if necessary)

References

Additional context

Discord username (if different from GitHub):
MrJigs

Testing instructions

1. Load aircraft
2. Power on EFB if necessary, check auto brightness is set to on in Flypad settings and quick settings

How to download the PR for QA

Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.

1. Make sure you are signed in to GitHub
2. Click on the Checks tab on the PR
3. On the left side, find and click on the PR Build tab
4. Click on either flybywire-aircraft-a320-neo, flybywire-aircraft-a380-842 (4K) or flybywire-aircraft-a380-842 (8K) download link at the bottom of the page

[heclak]

as part of the testing process, is there a need/steps to reset a user's settings? Or does a new build not read the existing settings? Curious if the testing is still valid if someone had already used a FBW aircraft and the old settings are already there.

[MrJigs7]

A new build does read existing settings as far as I’m aware. I tested this by loading the build and confirming the settings related to auto EFB brightness were applied on loading. I then set them to off, quit the flight, loaded back in and confirmed the settings were still set to off and user preference was therefore saved.

[heclak]

I meant if I already used another build of the A380 and had the auto-brightness set to on. How would i know if the auto-brightness on is because of your code change, or because of my previous setup. Just bringing this up to consider adding more details/steps in the testing steps.

If the EFB does read a users settings from another build, you might need to include testing steps to delete the previous saved config on their system before this test.

[tracernz]

Why does this touch the large files repo?

For the setting, you can delete that specific key from the data store in the Coherent debugger DeleteStoredData(key: string), so DeleteStoredData('EFB_USING_AUTOBRIGHTNESS').

[MrJigs7]

Why does this touch the large files repo?

For the setting, you can delete that specific key from the data store in the Coherent debugger DeleteStoredData(key: string), so DeleteStoredData('EFB_USING_AUTOBRIGHTNESS').

Apologies I think I accidentally committed all from both my aircraft source repository and my large files repository. Should I make a new commit without the large files changes?

[MrJigs7]

@tracernz I've tidied this PR up by removing the unnecessary commits including the accidental commit relating to the large files repo