-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Feat holds #471
docs: Feat holds #471
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/flybywire/docs/HAKRwwAjjLasAdERtetrFpmwxnNU |
Can you remove line 41 from - pilots-corner/advanced-guides/flight-planning/holds.md It'll be needed for the merge anyways and allows quick lookup when checkout ur preview thru vercel. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not a big fan of the tabs component. In my view it makes the page less readable and harder to divide into subsection which could be part of the in-page navigation.
I would especially avoid it for the programming hold part. A bullet point list would be much better in this case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small changes
Full feature review would be later just some things I noticed. Other things discussed in DMs for formatting can be done later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Image optimization noted. See Discord DMs to facilitate.
Heading suggestions as per issues at top of page (can move this around later):
# Overview
## Why Hold?
## Identifying Holds
## Hold Standards
## Programming Holds <- this separates the holding stuff from the standards before it
### MCDU Setup (maybe change this later but could come with new formatting)
### Descending in the Hold
### Leaving the Hold
Edited above.
Please ensure capitalization as indicated above.
Co-authored-by: Val <[email protected]>
Co-authored-by: Michael Corcoran <[email protected]>
Co-authored-by: Michael Corcoran <[email protected]>
Co-authored-by: Michael Corcoran <[email protected]>
Co-authored-by: Michael Corcoran <[email protected]>
Co-authored-by: Michael Corcoran <[email protected]>
Co-authored-by: Michael Corcoran <[email protected]>
Co-authored-by: Michael Corcoran <[email protected]>
Co-authored-by: Val <[email protected]>
df24f4b
to
8686e64
Compare
Deploying fbw-docs with Cloudflare Pages
|
Fixes #450
Summary
New guide to holds
Location
Edit: (Made by @Valastiri to add preview link)
Direct Preview Link
discord: Sven Janssens#6905