Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Feat holds #471

Merged
merged 40 commits into from
Sep 8, 2022
Merged

docs: Feat holds #471

merged 40 commits into from
Sep 8, 2022

Conversation

Sven-Janssens
Copy link
Contributor

@Sven-Janssens Sven-Janssens commented Mar 1, 2022

Fixes #450

Summary

New guide to holds

Location

Edit: (Made by @Valastiri to add preview link)
Direct Preview Link

discord: Sven Janssens#6905

@vercel
Copy link

vercel bot commented Mar 1, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/flybywire/docs/HAKRwwAjjLasAdERtetrFpmwxnNU
✅ Preview: https://docs-git-fork-sven-janssens-feat-holds-flybywire.vercel.app

@Valastiri
Copy link
Member

Valastiri commented Mar 8, 2022

Can you remove line 41 from mkdocs.yml?
This one below:

        - pilots-corner/advanced-guides/flight-planning/holds.md

It'll be needed for the merge anyways and allows quick lookup when checkout ur preview thru vercel. Thanks!

Copy link
Member

@frankkopp frankkopp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a big fan of the tabs component. In my view it makes the page less readable and harder to divide into subsection which could be part of the in-page navigation.

I would especially avoid it for the programming hold part. A bullet point list would be much better in this case.

Copy link
Member

@Valastiri Valastiri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small changes

Full feature review would be later just some things I noticed. Other things discussed in DMs for formatting can be done later.

Copy link
Member

@Valastiri Valastiri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image optimization noted. See Discord DMs to facilitate.

Heading suggestions as per issues at top of page (can move this around later):

# Overview
## Why Hold?
## Identifying Holds
## Hold Standards
## Programming Holds <- this separates the holding stuff from the standards before it
### MCDU Setup (maybe change this later but could come with new formatting)
### Descending in the Hold
### Leaving the Hold

Edited above.
Please ensure capitalization as indicated above.

Copy link

cloudflare-workers-and-pages bot commented Nov 16, 2024

Deploying fbw-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 9b40193
Status: ✅  Deploy successful!
Preview URL: https://2241ee4e.cf-fbw-docs.pages.dev

View logs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
advanced guides new documentation New documentation - new page repo Changes to Repo or Config
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Advanced Guide: HOLDS
6 participants