docs(disco): add warning about SID and en-route discontinuity #888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sleinmaster
requested changes
Sep 9, 2023
| !!! danger "" | ||
| There are some important things to note why you shouldn't normally clear a discontinuity: | ||
|
|
||
| - Turn radius between the two waypoints where the discontinuity is present |
There was a problem hiding this comment.
Suggested change
| - Turn radius between the two waypoints where the discontinuity is present | |
| - Narrow turn radii between the two waypoints, where the discontinuity is present, which could not be flown by the plane |
There was a problem hiding this comment.
added the word realistically
which could not be realistically flown by the plane
|
|
||
| - Turn radius between the two waypoints where the discontinuity is present | ||
| - Understanding the different [Leg Types](leg-types.md) and if they are compatible to be conneted together | ||
| - Even if the waypoints form a direct line, it's not inherently completely safe to remove a discontinuity unless you understand the above points |
There was a problem hiding this comment.
Suggested change
| - Even if the waypoints form a direct line, it's not inherently completely safe to remove a discontinuity unless you understand the above points | |
| - Even if the waypoints form a direct line, it's not inherently safe to remove a discontinuity unless you understand the above points |
Use inherently or completely, but not both.
Sleinmaster
reviewed
Sep 9, 2023
Co-authored-by: Sleinmaster <[email protected]>
github-actions
bot
merged commit e09926b
into
flybywiresim:primary
5 of 6 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Discussion in discord #docs channel over SID and en-route discontinuities. This PR clarifies with a new warning information why deleting discontinuities is something that should not be done lightly.
Reference:
Location
Discord username (if different from GitHub):
valastiri