From 66c8c8e734c8cd7fc511fedbaa8173b98d8a1688 Mon Sep 17 00:00:00 2001 From: Jason Parraga Date: Sat, 19 Oct 2024 14:42:34 -0700 Subject: [PATCH] Remove duplicate recovery interceptor Signed-off-by: Jason Parraga --- flyteadmin/pkg/server/service.go | 3 --- 1 file changed, 3 deletions(-) diff --git a/flyteadmin/pkg/server/service.go b/flyteadmin/pkg/server/service.go index 3c5197d6c8..fd8aecbf04 100644 --- a/flyteadmin/pkg/server/service.go +++ b/flyteadmin/pkg/server/service.go @@ -12,7 +12,6 @@ import ( "github.com/gorilla/handlers" grpcmiddleware "github.com/grpc-ecosystem/go-grpc-middleware" grpcauth "github.com/grpc-ecosystem/go-grpc-middleware/auth" - grpcrecovery "github.com/grpc-ecosystem/go-grpc-middleware/recovery" grpcprometheus "github.com/grpc-ecosystem/go-grpc-prometheus" "github.com/grpc-ecosystem/grpc-gateway/v2/runtime" "github.com/pkg/errors" @@ -111,7 +110,6 @@ func newGRPCServer(ctx context.Context, pluginRegistry *plugins.Registry, cfg *c chainedUnaryInterceptors = grpcmiddleware.ChainUnaryServer( // recovery interceptor should always be first in order to handle any panics in the middleware or server recoveryInterceptor.UnaryServerInterceptor(), - grpcrecovery.UnaryServerInterceptor(), grpcprometheus.UnaryServerInterceptor, otelUnaryServerInterceptor, auth.GetAuthenticationCustomMetadataInterceptor(authCtx), @@ -136,7 +134,6 @@ func newGRPCServer(ctx context.Context, pluginRegistry *plugins.Registry, cfg *c ) serverOpts := []grpc.ServerOption{ - // recovery interceptor should always be first in order to handle any panics in the middleware or server grpc.StreamInterceptor(chainedStreamInterceptors), grpc.UnaryInterceptor(chainedUnaryInterceptors), }