From 7d9dfe20c6017fdfb6402f8aafb1a6a8fe121226 Mon Sep 17 00:00:00 2001 From: Bugra Gedik Date: Thu, 17 Oct 2024 05:16:10 +0000 Subject: [PATCH] Review comments --- flytepropeller/pkg/controller/nodes/array/handler.go | 2 ++ 1 file changed, 2 insertions(+) diff --git a/flytepropeller/pkg/controller/nodes/array/handler.go b/flytepropeller/pkg/controller/nodes/array/handler.go index 4fa7b4ab5f..834a016cb2 100644 --- a/flytepropeller/pkg/controller/nodes/array/handler.go +++ b/flytepropeller/pkg/controller/nodes/array/handler.go @@ -500,10 +500,12 @@ func (a *arrayNodeHandler) Handle(ctx context.Context, nCtx interfaces.NodeExecu }{nil, err} continue } + // checkpoint paths are not computed here because this function is only called when writing // existing cached outputs. if this functionality changes this will need to be revisited. outputPaths := ioutils.NewCheckpointRemoteFilePaths(ctx, nCtx.DataStore(), subOutputDir, ioutils.NewRawOutputPaths(ctx, subDataDir), "") reader := ioutils.NewRemoteFileOutputReader(ctx, nCtx.DataStore(), outputPaths, 0) + gatherOutputsRequest.reader = &reader a.gatherOutputsRequestChannel <- gatherOutputsRequest }