From 856e606419a3756db8c4d8c0968bee80fbb445b4 Mon Sep 17 00:00:00 2001 From: Future-Outlier Date: Wed, 30 Oct 2024 23:12:30 +0800 Subject: [PATCH] add arrayNodeHandler comments Signed-off-by: Future-Outlier --- flytepropeller/pkg/controller/nodes/attr_path_resolver.go | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/flytepropeller/pkg/controller/nodes/attr_path_resolver.go b/flytepropeller/pkg/controller/nodes/attr_path_resolver.go index 222987ffa1..3b4e46ce50 100644 --- a/flytepropeller/pkg/controller/nodes/attr_path_resolver.go +++ b/flytepropeller/pkg/controller/nodes/attr_path_resolver.go @@ -162,8 +162,9 @@ func resolveAttrPathInBinary(nodeID string, binaryIDL *core.Binary, bindAttrPath } } - // if currVal is list, convert it to literal collection - // This is for map task handling + // In arrayNodeHandler, the resolved value should be a literal collection. + // If the current value is already a collection, convert it to a literal collection. + // This conversion does not affect how Flytekit processes the resolved value. if collection, ok := currVal.([]any); ok { literals := make([]*core.Literal, len(collection)) for i, v := range collection {