Skip to content

Commit bb6a70c

Browse files
committed
remove condition for ingress apiVersion
Signed-off-by: Ryan Lo <[email protected]>
1 parent 20f59d0 commit bb6a70c

File tree

3 files changed

+0
-183
lines changed

3 files changed

+0
-183
lines changed

charts/flyte-core/templates/_helpers.tpl

-60
Original file line numberDiff line numberDiff line change
@@ -268,145 +268,85 @@ storage:
268268
- path: /flyteidl.service.SignalService
269269
pathType: ImplementationSpecific
270270
backend:
271-
{{- if $.Capabilities.APIVersions.Has "networking.k8s.io/v1/Ingress" }}
272271
service:
273272
name: flyteadmin
274273
port:
275274
number: {{ $grpcPort }}
276-
{{- else }}
277-
serviceName: flyteadmin
278-
servicePort: {{ $grpcPort }}
279-
{{- end }}
280275
- path: /flyteidl.service.SignalService/*
281276
pathType: ImplementationSpecific
282277
backend:
283-
{{- if $.Capabilities.APIVersions.Has "networking.k8s.io/v1/Ingress" }}
284278
service:
285279
name: flyteadmin
286280
port:
287281
number: {{ $grpcPort }}
288-
{{- else }}
289-
serviceName: flyteadmin
290-
servicePort: {{ $grpcPort }}
291-
{{- end }}
292282
- path: /flyteidl.service.AdminService
293283
pathType: ImplementationSpecific
294284
backend:
295-
{{- if $.Capabilities.APIVersions.Has "networking.k8s.io/v1/Ingress" }}
296285
service:
297286
name: flyteadmin
298287
port:
299288
number: {{ $grpcPort }}
300-
{{- else }}
301-
serviceName: flyteadmin
302-
servicePort: {{ $grpcPort }}
303-
{{- end }}
304289
- path: /flyteidl.service.AdminService/*
305290
pathType: ImplementationSpecific
306291
backend:
307-
{{- if $.Capabilities.APIVersions.Has "networking.k8s.io/v1/Ingress" }}
308292
service:
309293
name: flyteadmin
310294
port:
311295
number: {{ $grpcPort }}
312-
{{- else }}
313-
serviceName: flyteadmin
314-
servicePort: {{ $grpcPort }}
315-
{{- end }}
316296
- path: /flyteidl.service.DataProxyService
317297
pathType: ImplementationSpecific
318298
backend:
319-
{{- if $.Capabilities.APIVersions.Has "networking.k8s.io/v1/Ingress" }}
320299
service:
321300
name: flyteadmin
322301
port:
323302
number: {{ $grpcPort }}
324-
{{- else }}
325-
serviceName: flyteadmin
326-
servicePort: {{ $grpcPort }}
327-
{{- end }}
328303
- path: /flyteidl.service.DataProxyService/*
329304
pathType: ImplementationSpecific
330305
backend:
331-
{{- if $.Capabilities.APIVersions.Has "networking.k8s.io/v1/Ingress" }}
332306
service:
333307
name: flyteadmin
334308
port:
335309
number: {{ $grpcPort }}
336-
{{- else }}
337-
serviceName: flyteadmin
338-
servicePort: {{ $grpcPort }}
339-
{{- end }}
340310
- path: /flyteidl.service.AuthMetadataService
341311
pathType: ImplementationSpecific
342312
backend:
343-
{{- if $.Capabilities.APIVersions.Has "networking.k8s.io/v1/Ingress" }}
344313
service:
345314
name: flyteadmin
346315
port:
347316
number: {{ $grpcPort }}
348-
{{- else }}
349-
serviceName: flyteadmin
350-
servicePort: {{ $grpcPort }}
351-
{{- end }}
352317
- path: /flyteidl.service.AuthMetadataService/*
353318
pathType: ImplementationSpecific
354319
backend:
355-
{{- if $.Capabilities.APIVersions.Has "networking.k8s.io/v1/Ingress" }}
356320
service:
357321
name: flyteadmin
358322
port:
359323
number: {{ $grpcPort }}
360-
{{- else }}
361-
serviceName: flyteadmin
362-
servicePort: {{ $grpcPort }}
363-
{{- end }}
364324
- path: /flyteidl.service.IdentityService
365325
pathType: ImplementationSpecific
366326
backend:
367-
{{- if $.Capabilities.APIVersions.Has "networking.k8s.io/v1/Ingress" }}
368327
service:
369328
name: flyteadmin
370329
port:
371330
number: {{ $grpcPort }}
372-
{{- else }}
373-
serviceName: flyteadmin
374-
servicePort: {{ $grpcPort }}
375-
{{- end }}
376331
- path: /flyteidl.service.IdentityService/*
377332
pathType: ImplementationSpecific
378333
backend:
379-
{{- if $.Capabilities.APIVersions.Has "networking.k8s.io/v1/Ingress" }}
380334
service:
381335
name: flyteadmin
382336
port:
383337
number: {{ $grpcPort }}
384-
{{- else }}
385-
serviceName: flyteadmin
386-
servicePort: {{ $grpcPort }}
387-
{{- end }}
388338
- path: /grpc.health.v1.Health
389339
pathType: ImplementationSpecific
390340
backend:
391-
{{- if $.Capabilities.APIVersions.Has "networking.k8s.io/v1/Ingress" }}
392341
service:
393342
name: flyteadmin
394343
port:
395344
number: {{ $grpcPort }}
396-
{{- else }}
397-
serviceName: flyteadmin
398-
servicePort: {{ $grpcPort }}
399-
{{- end }}
400345
- path: /grpc.health.v1.Health/*
401346
pathType: ImplementationSpecific
402347
backend:
403-
{{- if $.Capabilities.APIVersions.Has "networking.k8s.io/v1/Ingress" }}
404348
service:
405349
name: flyteadmin
406350
port:
407351
number: {{ $grpcPort }}
408-
{{- else }}
409-
serviceName: flyteadmin
410-
servicePort: {{ $grpcPort }}
411-
{{- end }}
412352
{{- end -}}

charts/flyte-core/templates/common/ingress-grpc.yaml

-4
Original file line numberDiff line numberDiff line change
@@ -5,11 +5,7 @@
55
{{- $annotations := .Values.common.ingress.annotations | deepCopy -}}
66
{{- $_ := merge $annotations .Values.common.ingress.separateGrpcIngressAnnotations -}}
77

8-
{{- if $.Capabilities.APIVersions.Has "networking.k8s.io/v1/Ingress" }}
98
apiVersion: networking.k8s.io/v1
10-
{{- else }}
11-
apiVersion: networking.k8s.io/v1beta1
12-
{{- end }}
139
kind: Ingress
1410
metadata:
1511
name: {{ template "flyte.name" . }}-grpc

0 commit comments

Comments
 (0)