From d2f68bab1fbdada955a8bb2709e8f843e39bd161 Mon Sep 17 00:00:00 2001 From: troychiu Date: Thu, 14 Mar 2024 15:14:47 -0700 Subject: [PATCH] fix config Signed-off-by: troychiu --- .github/workflows/integration.yml | 3 --- flyteadmin/script/integration/k8s/integration.yaml | 3 +++ flyteadmin/tests/bootstrap.go | 1 - 3 files changed, 3 insertions(+), 4 deletions(-) diff --git a/.github/workflows/integration.yml b/.github/workflows/integration.yml index 093f49a585..ba640f851c 100644 --- a/.github/workflows/integration.yml +++ b/.github/workflows/integration.yml @@ -39,8 +39,6 @@ jobs: with: go-version: ${{ inputs.go-version }} - name: Integration - env: - USE_LOCAL_SANDBOX: ${{ false }} run: | # attempt to clean up some unneeded data: https://github.com/actions/virtual-environments/issues/2840#issuecomment-790492173 sudo rm -rf /usr/share/dotnet @@ -51,5 +49,4 @@ jobs: kubectl get pods -n kube-system echo "current-context:" $(kubectl config current-context) echo "environment-kubeconfig:" ${KUBECONFIG} - echo "USE_LOCAL_SANDBOX:" ${USE_LOCAL_SANDBOX} IMAGE_NAME=${{ inputs.component }} IMAGE=${{ github.repository_owner }}/${{ inputs.component }}:builder make k8s_integration_execute diff --git a/flyteadmin/script/integration/k8s/integration.yaml b/flyteadmin/script/integration/k8s/integration.yaml index 4fae0bab27..db67f82b7e 100644 --- a/flyteadmin/script/integration/k8s/integration.yaml +++ b/flyteadmin/script/integration/k8s/integration.yaml @@ -417,6 +417,9 @@ spec: - name: flyteadmin image: flyteadmin:test imagePullPolicy: IfNotPresent + env: + - name: USE_LOCAL_SANDBOX + value: "False" securityContext: privileged: true readinessProbe: diff --git a/flyteadmin/tests/bootstrap.go b/flyteadmin/tests/bootstrap.go index dcb2ae45d4..b3950b0b84 100644 --- a/flyteadmin/tests/bootstrap.go +++ b/flyteadmin/tests/bootstrap.go @@ -25,7 +25,6 @@ const sandboxEnv = "USE_LOCAL_SANDBOX" var adminScope = promutils.NewScope("flyteadmin") func getDbConfigWithEnv() *database.DbConfig { - fmt.Printf("USE_LOCAL_SANDBOX: %s\n", os.Getenv(sandboxEnv)) if os.Getenv(sandboxEnv) == "False" { return getDbConfig() } else {