From e5fbee4942fadb116f5d71b352b62625d57be5a7 Mon Sep 17 00:00:00 2001 From: Yee Hing Tong Date: Sun, 8 Sep 2024 15:56:03 -0700 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Nikki Everett Signed-off-by: Yee Hing Tong --- docs/flyte_fundamentals/registering_workflows.md | 11 +++++------ docs/user_guide/customizing_dependencies/imagespec.md | 6 ++++-- 2 files changed, 9 insertions(+), 8 deletions(-) diff --git a/docs/flyte_fundamentals/registering_workflows.md b/docs/flyte_fundamentals/registering_workflows.md index 321593db25..8a5ec83c14 100644 --- a/docs/flyte_fundamentals/registering_workflows.md +++ b/docs/flyte_fundamentals/registering_workflows.md @@ -260,13 +260,12 @@ metadata/configuration, it's more secure if they're private. Learn more about how to pull private image in the {ref}`User Guide `. ``` -##### Relationship between ImageSpec and Fast Registration -The `ImageSpec` construct available in flytekit also has a mechanism to copy files into the image being built. By default, the way it works is -* if fast register is used, then it's assumed that you don't also want to copy source files into built image. -* if fast register is not used (which is the default for `pyflyte package`, or if `pyflyte register --copy none` is specified), then it's assumed that - you do want source files copied. +##### Relationship between ImageSpec and fast registration +The `ImageSpec` construct available in flytekit also has a mechanism to copy files into the image being built. Its behavior depends on the type of registration used: +* If fast register is used, then it's assumed that you don't also want to copy source files into the built image. +* If fast register is not used (which is the default for `pyflyte package`, or if `pyflyte register --copy none` is specified), then it's assumed that you do want source files copied into the built image. -In any case, if your `ImageSpec` constructor specifies a `source_root` and the `copy` argument set to something other than `CopyFileDetection.NO_COPY`, then files will be copied regardless of fast registration status. +If your `ImageSpec` constructor specifies a `source_root` and the `copy` argument is set to something other than `CopyFileDetection.NO_COPY`, then files will be copied regardless of fast registration status. #### Package your project with `pyflyte package` diff --git a/docs/user_guide/customizing_dependencies/imagespec.md b/docs/user_guide/customizing_dependencies/imagespec.md index bf5d6fc32e..5128e9601c 100644 --- a/docs/user_guide/customizing_dependencies/imagespec.md +++ b/docs/user_guide/customizing_dependencies/imagespec.md @@ -106,6 +106,8 @@ image = ImageSpec(registry="ghcr.io/flyteorg", packages=["pandas"]).force_push() ## Getting source files into ImageSpec Typically, getting source code files into a task's image at run time on a live Flyte backend is done through the fast registration mechanism. -If the `source_root` and `copy` fields to an `ImageSpec` are left blank, then whether or not your source files are copied into the built `ImageSpec` image is basically the inverse of whether fast register is used. Please see [registering workflows](https://docs.flyte.org/en/latest/flyte_fundamentals/registering_workflows.html#containerizing-your-project) for the full explanation. -Keep in mind that because files are sometimes copied into the built image, the tag that is published for an ImageSpec will change based on whether fast register is enabled, and the contents of any files copied. +However, if your `ImageSpec` constructor specifies a `source_root` and the `copy` argument is set to something other than `CopyFileDetection.NO_COPY`, then files will be copied regardless of fast registration status. +If the `source_root` and `copy` fields to an `ImageSpec` are left blank, then whether or not your source files are copied into the built `ImageSpec` image depends on whether or not you use fast registration. Please see [registering workflows](https://docs.flyte.org/en/latest/flyte_fundamentals/registering_workflows.html#containerizing-your-project) for the full explanation. + +Since files are sometimes copied into the built image, the tag that is published for an ImageSpec will change based on whether fast register is enabled, and the contents of any files copied.