Datacatalog migrations throws a panic error

[stephen37]

The datacatalog migration/server fails to start and throws the following errors:

/tmp/config # datacatalog migrate run --config='/tmp/config/*.yaml'
Warn: No metricsProvider set for the workqueue
Using config file:  [/tmp/config/db.yaml /tmp/config/logger.yaml /tmp/config/server.yaml /tmp/config/storage.yaml]
INFO[0000] Using config file: [/tmp/config/db.yaml /tmp/config/logger.yaml /tmp/config/server.yaml /tmp/config/storage.yaml] 
INFO[0000] Config section [logger] updated. Firing updated event.  src="viper.go:320"
panic: interface conversion: error is *errors.errorString, not *pgconn.PgError

goroutine 1 [running]:
github.com/flyteorg/datacatalog/cmd/entrypoints.glob..func1(0x21e3820, 0xc000484520, 0x0, 0x1)
	/go/src/github.com/lyft/datacatalog/cmd/entrypoints/migrate.go:51 +0xbb4
github.com/spf13/cobra.(*Command).execute(0x21e3820, 0xc000484510, 0x1, 0x1, 0x21e3820, 0xc000484510)
	/go/pkg/mod/github.com/spf13/[email protected]/command.go:854 +0x2aa
github.com/spf13/cobra.(*Command).ExecuteC(0x21e3ac0, 0x14aed2e, 0x1, 0xffffffffffffffff)
	/go/pkg/mod/github.com/spf13/[email protected]/command.go:958 +0x349
github.com/spf13/cobra.(*Command).Execute(...)
	/go/pkg/mod/github.com/spf13/[email protected]/command.go:895
github.com/flyteorg/datacatalog/cmd/entrypoints.Execute(0xc000000002, 0x405700)
	/go/src/github.com/lyft/datacatalog/cmd/entrypoints/root.go:44 +0x31
main.main()
	/go/src/github.com/lyft/datacatalog/cmd/main.go:10 +0x59

We also have another error when running the serve command about failed to parse as DSN (invalid dsn)

{
  "json": { "src": "service.go:69" },
  "level": "fatal",
  "msg": "caught panic: cannot parse `host=xxx.rds.amazonaws.com port=5432 dbname=flyte user=username password=xxxxx `: failed to parse as DSN (invalid dsn) [goroutine 1 [running]:\nruntime/debug.Stack(0xc000648960, 0x14c2cf8, 0x14)\n\t/usr/local/go/src/runtime/debug/stack.go:24 +0x9d\ngithub.com/flyteorg/datacatalog/pkg/rpc/datacatalogservice.NewDataCatalogService.func1(0x1851400, 0xc00040d4a0)\n\t/go/src/github.com/lyft/datacatalog/pkg/rpc/datacatalogservice/service.go:69 +0xbe\npanic(0x12e65e0, 0xc000738c30)\n\t/usr/local/go/src/runtime/panic.go:679 +0x1b2\ngithub.com/flyteorg/datacatalog/pkg/repositories.GetRepository(0x0, 0x0, 0x0, 0xc000192140, 0x4c, 0x1538, 0xc0002c9c68, 0x5, 0xc0002c9c40, 0xb, ...)\n\t/go/src/github.com/lyft/datacatalog/pkg/repositories/factory.go:36 +0x2e3\ngithub.com/flyteorg/datacatalog/pkg/rpc/datacatalogservice.NewDataCatalogService(0x0)\n\t/go/src/github.com/lyft/datacatalog/pkg/rpc/datacatalogservice/service.go:97 +0x717\ngithub.com/flyteorg/datacatalog/cmd/entrypoints.newGRPCServer(0x1835ca0, 0xc000044080, 0xc000173500, 0xb04369)\n\t/go/src/github.com/lyft/datacatalog/cmd/entrypoints/serve.go:58 +0x45\ngithub.com/flyteorg/datacatalog/cmd/entrypoints.serveInsecure(0x1835ca0, 0xc000044080, 0xc000173500, 0xc000044080, 0xc000173500)\n\t/go/src/github.com/lyft/datacatalog/cmd/entrypoints/serve.go:44 +0x4c\ngithub.com/flyteorg/datacatalog/cmd/entrypoints.glob..func3(0x21e3d60, 0xc000482550, 0x0, 0x1, 0x0, 0x0)\n\t/go/src/github.com/lyft/datacatalog/cmd/entrypoints/serve.go:34 +0xb9\ngithub.com/spf13/cobra.(*Command).execute(0x21e3d60, 0xc000482540, 0x1, 0x1, 0x21e3d60, 0xc000482540)\n\t/go/pkg/mod/github.com/spf13/[email protected]/command.go:850 +0x460\ngithub.com/spf13/cobra.(*Command).ExecuteC(0x21e3ac0, 0x14aed2e, 0x1, 0xffffffffffffffff)\n\t/go/pkg/mod/github.com/spf13/[email protected]/command.go:958 +0x349\ngithub.com/spf13/cobra.(*Command).Execute(...)\n\t/go/pkg/mod/github.com/spf13/[email protected]/command.go:895\ngithub.com/flyteorg/datacatalog/cmd/entrypoints.Execute(0xc000000002, 0x405700)\n\t/go/src/github.com/lyft/datacatalog/cmd/entrypoints/root.go:44 +0x31\nmain.main()\n\t/go/src/github.com/lyft/datacatalog/cmd/main.go:10 +0x59\n]",
  "ts": "2021-09-13T13:00:41Z",
}

[stephen37]

The error suggests that there might be a problem in our db.yaml config file. On our side, the problem was because we had an newline character in the passwordPath file. To solve that problem, we ran cat pass.txt | tr -d '\n' > pass2.txt and it made the trick 😄

[EngHabu]

The error suggests that there might be a problem in our db.yaml config file. On our side, the problem was because we had an newline character in the passwordPath file. To solve that problem, we ran cat pass.txt | tr -d '\n' > pass2.txt and it made the trick 😄

Do you mind duplicating this PR flyteorg/datacatalog#56 for flyteadmin as well?

[stephen37]

Sure, here it is flyteorg/flyteadmin#281