-
Notifications
You must be signed in to change notification settings - Fork 671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Housekeeping] Dockerize call to "go generate" in flyteidl makefile #2911
Comments
I've created a PR to implement this in flyteorg/flyteidl#338, which not only dockerizes |
Hello 👋, This issue has been inactive for over 9 months. To help maintain a clean and focused backlog, we'll be marking this issue as stale and will close the issue if we detect no activity in the next 7 days. Thank you for your contribution and understanding! 🙏 |
Hello 👋, This issue has been inactive for over 9 months and hasn't received any updates since it was marked as stale. We'll be closing this issue for now, but if you believe this issue is still relevant, please feel free to reopen it. Thank you for your contribution and understanding! 🙏 |
Hello 👋, this issue has been inactive for over 9 months. To help maintain a clean and focused backlog, we'll be marking this issue as stale and will engage on it to decide if it is still applicable. |
@eapolinario is this still an issue? |
Describe the issue
Differences in the versions of the go toolchain cause the build scripts to fail (e.g. in flyteorg/flyteidl#321 we noticed that the build failed because we were running
make generate
with versions 1.18.6 and 1.19).Instead, we should control the environment in which the calls to
go generate
happen, by, for example, running that in a docker container, where we can install (and test) specific versions of the go toolchain.What if we do not do this?
We will keep seeing these little discrepancies, depending on the systems where those make targets are invoked.
Related component(s)
flyteidl
Are you sure this issue hasn't been raised already?
Have you read the Code of Conduct?
The text was updated successfully, but these errors were encountered: