Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Housekeeping] Dockerize call to "go generate" in flyteidl makefile #2911

Open
2 tasks done
Tracked by #2917
eapolinario opened this issue Sep 22, 2022 · 5 comments
Open
2 tasks done
Tracked by #2917
Labels
housekeeping Issues that help maintain flyte and keep it tech-debt free stale

Comments

@eapolinario
Copy link
Contributor

Describe the issue

Differences in the versions of the go toolchain cause the build scripts to fail (e.g. in flyteorg/flyteidl#321 we noticed that the build failed because we were running make generate with versions 1.18.6 and 1.19).

Instead, we should control the environment in which the calls to go generate happen, by, for example, running that in a docker container, where we can install (and test) specific versions of the go toolchain.

What if we do not do this?

We will keep seeing these little discrepancies, depending on the systems where those make targets are invoked.

Related component(s)

flyteidl

Are you sure this issue hasn't been raised already?

  • Yes

Have you read the Code of Conduct?

  • Yes
@daniel-shuy
Copy link
Contributor

I've created a PR to implement this in flyteorg/flyteidl#338, which not only dockerizes go generate, but the entire dev environment

@github-actions
Copy link

github-actions bot commented Sep 5, 2023

Hello 👋, This issue has been inactive for over 9 months. To help maintain a clean and focused backlog, we'll be marking this issue as stale and will close the issue if we detect no activity in the next 7 days. Thank you for your contribution and understanding! 🙏

@github-actions github-actions bot added the stale label Sep 5, 2023
@github-actions
Copy link

Hello 👋, This issue has been inactive for over 9 months and hasn't received any updates since it was marked as stale. We'll be closing this issue for now, but if you believe this issue is still relevant, please feel free to reopen it. Thank you for your contribution and understanding! 🙏

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Sep 12, 2023
@eapolinario eapolinario reopened this Nov 2, 2023
@github-actions github-actions bot removed the stale label Nov 4, 2023
Copy link

github-actions bot commented Aug 2, 2024

Hello 👋, this issue has been inactive for over 9 months. To help maintain a clean and focused backlog, we'll be marking this issue as stale and will engage on it to decide if it is still applicable.
Thank you for your contribution and understanding! 🙏

@github-actions github-actions bot added the stale label Aug 2, 2024
@davidmirror-ops
Copy link
Contributor

@eapolinario is this still an issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
housekeeping Issues that help maintain flyte and keep it tech-debt free stale
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants