Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Housekeeping] Better Task proto buff errors #3027

Closed
2 tasks done
Tracked by #2917
jerempy opened this issue Oct 25, 2022 · 0 comments
Closed
2 tasks done
Tracked by #2917

[Housekeeping] Better Task proto buff errors #3027

jerempy opened this issue Oct 25, 2022 · 0 comments
Assignees
Labels
hacktoberfest housekeeping Issues that help maintain flyte and keep it tech-debt free

Comments

@jerempy
Copy link
Contributor

jerempy commented Oct 25, 2022

Describe the issue

#2522 This raised the issue of missing data for CreateWorkflowRequests. This lead to creating new protobufs: https://github.com/jerempy/flyteidl/blob/8a7a0df7788c5ae817f234ef3bf980fee1d1ee9e/protos/flyteidl/admin/workflow.proto#L70-L85

And new errors from flyteadmin:
https://github.com/flyteorg/flyteadmin/blob/f12dd2a674a3ac3bca43dd1d230dbddb73c7288b/pkg/errors/errors.go#L117-L130

@EngHabu brought up replicating these for Tasks in addition to Workflows. Good idea - making an issue to track this.

What if we do not do this?

Probably not much - but could be good improvement.

Related component(s)

flyteidl, flyteadmin

Are you sure this issue hasn't been raised already?

  • Yes

Have you read the Code of Conduct?

  • Yes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest housekeeping Issues that help maintain flyte and keep it tech-debt free
Projects
None yet
Development

No branches or pull requests

3 participants