-
Notifications
You must be signed in to change notification settings - Fork 674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UI Feature] Flyte runtime metrics UI #3405
Comments
@jsonporter we need to come up with a few mockups of how this looks. Open questions include:
|
@cosmicBboy I am wondering why the 'view details' toggle ? do we incur a performance hit to bring the additional details to the UI? I am, in general, in favor of "opt-in to complexity" but with this design I don't see the details being visually overwhelming and rather think the toggle introduces unnecessary clutter and cognitive load. Put another way, why would I not want the sectioned display? |
@tsheiner we should discuss further with @jsonporter, I'm agnostic to what approach we take here, but he may have more context on this decision. |
@jsonporter @tsheiner let's update the comps so that the new runtime metrics view is the default, no need for the toggle button.
|
@4nalog updated comps ^^^ |
The design looks nice, I would even prefer to highlight the actual runtime even more than the other phases. @jsonporter This is marked as done in the roadmap, but I only see basic hover tooltips in 1.6... |
closing as completed |
Motivation: Why do you think this is important?
#3272
Goal: What should the final outcome look like, ideally?
UPDATE: New
There have been some changes from the original spec/comps.
operationId
it represents.depth=0
and will revisit this to better optimize performance in later versions if this feature starts gaining traction.--- The following is out of date in the listed cases ---
The new UI will be controlled by a toggle ("View Details") and will break up the graph into sections. The colors for these new buckets should be opacity values on black/white overlayed over the existing phase color. Crucially, these overlayed values should be consistent across events (eg, the overlay treatment applied to "plugin" durations should be the same regardless of phase)
Propose: Link/Inline OR Additional context
See high-level proposal here
Are you sure this issue hasn't been raised already?
Have you read the Code of Conduct?
The text was updated successfully, but these errors were encountered: