Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI Feature] Flyte runtime metrics UI #3405

Closed
2 tasks done
cosmicBboy opened this issue Mar 6, 2023 · 8 comments
Closed
2 tasks done

[UI Feature] Flyte runtime metrics UI #3405

cosmicBboy opened this issue Mar 6, 2023 · 8 comments
Assignees
Labels
enhancement New feature or request ui Admin console user interface untriaged This issues has not yet been looked at by the Maintainers
Milestone

Comments

@cosmicBboy
Copy link
Contributor

cosmicBboy commented Mar 6, 2023

Motivation: Why do you think this is important?

#3272

Goal: What should the final outcome look like, ideally?

UPDATE: New

There have been some changes from the original spec/comps.

  1. We will no longer use color/opacity values. Instead, simply render the lines between spans. Users can hover over a span to see which operationId it represents.
  2. We will fetch all execution spans using depth=0 and will revisit this to better optimize performance in later versions if this feature starts gaining traction.
  3. The hover tool-tip will be handled in a separate ticket.

--- The following is out of date in the listed cases ---

The new UI will be controlled by a toggle ("View Details") and will break up the graph into sections. The colors for these new buckets should be opacity values on black/white overlayed over the existing phase color. Crucially, these overlayed values should be consistent across events (eg, the overlay treatment applied to "plugin" durations should be the same regardless of phase)

Image

Image

Image

Propose: Link/Inline OR Additional context

See high-level proposal here

Are you sure this issue hasn't been raised already?

  • Yes

Have you read the Code of Conduct?

  • Yes
@cosmicBboy cosmicBboy added enhancement New feature or request ui Admin console user interface untriaged This issues has not yet been looked at by the Maintainers labels Mar 6, 2023
@cosmicBboy cosmicBboy added this to the 1.5.0 milestone Mar 6, 2023
@cosmicBboy
Copy link
Contributor Author

@jsonporter we need to come up with a few mockups of how this looks. Open questions include:

  • how to visualize the different buckets?
  • color scheme? legend? tooltip?

@cosmicBboy cosmicBboy changed the title [UI Feature] Flyte runtime metrics [UI Feature] Flyte runtime metrics UI Mar 10, 2023
@tsheiner
Copy link
Contributor

@cosmicBboy I am wondering why the 'view details' toggle ?

do we incur a performance hit to bring the additional details to the UI?

I am, in general, in favor of "opt-in to complexity" but with this design I don't see the details being visually overwhelming and rather think the toggle introduces unnecessary clutter and cognitive load.

Put another way, why would I not want the sectioned display?

@cosmicBboy
Copy link
Contributor Author

@tsheiner we should discuss further with @jsonporter, I'm agnostic to what approach we take here, but he may have more context on this decision.

@cosmicBboy
Copy link
Contributor Author

@jsonporter @tsheiner let's update the comps so that the new runtime metrics view is the default, no need for the toggle button.

  • if the performance hit is too much for large dynamic nodes, for example, we can revisit the toggle button UI.

@tsheiner
Copy link
Contributor

Updated design:

default state

hover over state

@tsheiner
Copy link
Contributor

@4nalog updated comps ^^^

@flixr
Copy link
Contributor

flixr commented May 15, 2023

The design looks nice, I would even prefer to highlight the actual runtime even more than the other phases.

@jsonporter This is marked as done in the roadmap, but I only see basic hover tooltips in 1.6...
Is there a follow up planned for 1.7?

@hamersaw
Copy link
Contributor

hamersaw commented Dec 1, 2023

closing as completed

@hamersaw hamersaw closed this as completed Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ui Admin console user interface untriaged This issues has not yet been looked at by the Maintainers
Projects
None yet
Development

No branches or pull requests

6 participants