Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Setting ephemeral_storage request automatically sets ephemeral_storage limit with equal value #3941

Open
2 tasks done
LukasBommes opened this issue Aug 10, 2023 · 2 comments
Assignees
Labels
bug Something isn't working stale

Comments

@LukasBommes
Copy link

LukasBommes commented Aug 10, 2023

Describe the bug

This task annotation

@task(
    requests=Resources(cpu="100m", mem="100Mi", ephemeral_storage="20Gi"),
    limits=Resources(cpu="1", mem="1Gi"),
)

leads to the following pod spec in Kubernetes

    Limits:
      cpu:                1
      ephemeral-storage:  20Gi
      memory:             1Gi
    Requests:
      cpu:                100m
      ephemeral-storage:  20Gi
      memory:             100Mi

Expected behavior

However, I expect the resulting pod spec to look like this

    Limits:
      cpu:                1
      memory:             1Gi
    Requests:
      cpu:                100m
      ephemeral-storage:  20Gi
      memory:             100Mi

I.e., there should be no limit set for ephemeral-storage.

Additional context to reproduce

On-prem deployment of flyte-binary 1.8.1

Screenshots

No response

Are you sure this issue hasn't been raised already?

  • Yes

Have you read the Code of Conduct?

  • Yes
@LukasBommes LukasBommes added bug Something isn't working untriaged This issues has not yet been looked at by the Maintainers labels Aug 10, 2023
@eapolinario eapolinario removed the untriaged This issues has not yet been looked at by the Maintainers label Aug 11, 2023
@flixr
Copy link
Contributor

flixr commented Sep 1, 2023

This is basically a duplicate of #3574 as this happens for all limits.

Copy link

Hello 👋, this issue has been inactive for over 9 months. To help maintain a clean and focused backlog, we'll be marking this issue as stale and will engage on it to decide if it is still applicable.
Thank you for your contribution and understanding! 🙏

@github-actions github-actions bot added the stale label May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working stale
Projects
None yet
Development

No branches or pull requests

4 participants