Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] remote workflow called in conditional branch ran into issue #4184

Closed
2 tasks done
Tracked by #4064
ysysys3074 opened this issue Oct 6, 2023 · 1 comment · Fixed by flyteorg/flytekit#1890
Closed
2 tasks done
Tracked by #4064
Labels
bug Something isn't working hacktoberfest

Comments

@ysysys3074
Copy link
Contributor

ysysys3074 commented Oct 6, 2023

Describe the bug

I have the code below which invoked a reference_launch_plan called data_launch_plan inside then() branch of conditional, but got KeyError: LAUNCH_PLAN:XXX in compile time. I suspect the issue is due to this https://github.com/flyteorg/flytekit/blob/master/flytekit/remote/remote.py#L364 as node_launch_plans is empty dict from what I saw. And data_launch_plan is working and node_launch_plans is with values when calling it in a normal way.

featurized_dataset_location = (
        conditional("test")
            .if_(has_config.is_true())
            .then(
                data_launch_plan(
                    proxy_as=proxy_as,
                    name=name,
                )
            )
            .else_()
            .then(test(a=a))

Expected behavior

Since this is a TODO, can you plz help to fix this https://github.com/flyteorg/flytekit/blob/master/flytekit/remote/remote.py

Additional context to reproduce

No response

Screenshots

No response

Are you sure this issue hasn't been raised already?

  • Yes

Have you read the Code of Conduct?

  • Yes
@ysysys3074 ysysys3074 added bug Something isn't working untriaged This issues has not yet been looked at by the Maintainers labels Oct 6, 2023
@welcome
Copy link

welcome bot commented Oct 6, 2023

Thank you for opening your first issue here! 🛠

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working hacktoberfest
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants