-
Notifications
You must be signed in to change notification settings - Fork 670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Support serializing Scheduled Executions #420
Comments
Exactly once means that something will be done exactly once, not twice and not zero times. @EngHabu Do you rather mean that only one scheduled execution runs at a time effectively serial iz Ing the schedules? |
Yes exactly that |
this should dedupe - #267 |
Cc @EngHabu this should not be closed |
* removed the secrets package to flyteplugins and updated dependencies Signed-off-by: Daniel Rammer <[email protected]> * fixed lint issue Signed-off-by: Daniel Rammer <[email protected]> * updated flyteplugins version Signed-off-by: Daniel Rammer <[email protected]> * Update deps Signed-off-by: Haytham Abuelfutuh <[email protected]> Co-authored-by: Haytham Abuelfutuh <[email protected]>
…teorg#427) This reverts commit d0bda09. Signed-off-by: Katrina Rogan <[email protected]>
* Add s3 bucket Signed-off-by: Felix Wang <[email protected]> * Switch from minio to s3 client Signed-off-by: Felix Wang <[email protected]> * Small fixes Signed-off-by: Felix Wang <[email protected]>
…yteorg#420) Signed-off-by: Nastya Rusina <[email protected]>
## [0.54.2](http://github.com/lyft/flyteconsole/compare/v0.54.1...v0.54.2) (2022-04-22) ### Bug Fixes * on project select navigate to corresponding ProjectDashboard ([flyteorg#420](http://github.com/lyft/flyteconsole/issues/420)) ([a855f9b](http://github.com/lyft/flyteconsole/commit/a855f9b523b12a0b1fa0e4d1df09ff6d5e31b1b9))
* removed the secrets package to flyteplugins and updated dependencies Signed-off-by: Daniel Rammer <[email protected]> * fixed lint issue Signed-off-by: Daniel Rammer <[email protected]> * updated flyteplugins version Signed-off-by: Daniel Rammer <[email protected]> * Update deps Signed-off-by: Haytham Abuelfutuh <[email protected]> Co-authored-by: Haytham Abuelfutuh <[email protected]>
…teorg#427) This reverts commit c1489d8. Signed-off-by: Katrina Rogan <[email protected]>
Hello 👋, This issue has been inactive for over 9 months. To help maintain a clean and focused backlog, we'll be marking this issue as stale and will close the issue if we detect no activity in the next 7 days. Thank you for your contribution and understanding! 🙏 |
Hello 👋, This issue has been inactive for over 9 months and hasn't received any updates since it was marked as stale. We'll be closing this issue for now, but if you believe this issue is still relevant, please feel free to reopen it. Thank you for your contribution and understanding! 🙏 |
--------- Signed-off-by: Future Outlier <[email protected]> Signed-off-by: Future-Outlier <[email protected]> Co-authored-by: Future Outlier <[email protected]> Co-authored-by: Kevin Su <[email protected]>
--------- Signed-off-by: Future Outlier <[email protected]> Signed-off-by: Future-Outlier <[email protected]> Co-authored-by: Future Outlier <[email protected]> Co-authored-by: Kevin Su <[email protected]>
--------- Signed-off-by: Future Outlier <[email protected]> Signed-off-by: Future-Outlier <[email protected]> Co-authored-by: Future Outlier <[email protected]> Co-authored-by: Kevin Su <[email protected]>
--------- Signed-off-by: Future Outlier <[email protected]> Signed-off-by: Future-Outlier <[email protected]> Co-authored-by: Future Outlier <[email protected]> Co-authored-by: Kevin Su <[email protected]>
@kumare3 any possibility of making this happen? |
This is on the roadmap, cannot be prioritized right now as short staffed. Please contribute! |
Cc @EngHabu @eapolinario fyi |
@kdhingra307 please share a motivating example / usecase |
@kumare3 One use-case could involve processing a batch of data from a stream. For example, if we are at index 10 and want to process the next 500 samples, we increase the counter once the workflow is complete. However, if the workflow takes longer to finish than the frequency at which new workflows are launched, another workflow might start and process the same data. Also, i can try working on this |
@kumare3 i feel the logic to implement skip feature would be relatively easier. We can add a check in PrepareFlyteWorkflow function and check if a copy of same workflow is running or not. I did a small poc locally and it seems to be working fine. otpt, _ := w.adminServiceClient.ListExecutions(context.Background(), &admin.ResourceListRequest{
Id: &admin.NamedEntityIdentifier{Project: "flytesnacks", Domain: "development"},
Filters: "eq(launch_plan.name,my_cron_scheduled_lp)+value_in(phase,RUNNING)",
Limit: 1,
})
if otpt.Token == "" {
return nil
} else {
logger.Errorf(ctx, "it already exists so skipping")
return nil
} Making the workflow wait for the previous one is bit tricky, like i feel it can be done by adding a condition in handleReadyWorkflow to keep in |
@kdhingra307 , take a look at #5659 where we discussing this idea. |
Motivation: Why do you think this is important?
With a scheduled executions, users might expect no more than one execution will be running at the same time (assuming an older run takes a long time to finish).
Goal: What should the final outcome look like, ideally?
Users can signify exactly once flag when creating a schedule for a launch plan.
Flyte component
The text was updated successfully, but these errors were encountered: