Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[Monorepo] Enable proxy-authorization in admin client (#4189)" #4216

Closed
wants to merge 1 commit into from

Conversation

andrewwdye
Copy link
Contributor

Describe your changes

Looks like this may have broken propeller -> admin events when auth is enabled

panic({0x25fb2e0, 0xc0024577d0})
	/usr/local/go/src/runtime/panic.go:884 +0x212
github.com/flyteorg/flyte/flyteidl/clients/go/admin/externalprocess.Execute({0x423f5f8?, 0x8?, 0x7f15bee905b8?})
	/go/src/github.com/flyteorg/flyteidl/clients/go/admin/externalprocess/command_executor.go:6 +0x68
github.com/flyteorg/flyte/flyteidl/clients/go/admin.ExternalTokenSourceProvider.GetTokenSource({{0x423f5f8?, 0x40dc87?, 0x18?}}, {0x248cec0?, 0x7f1597747501?})
	/go/src/github.com/flyteorg/flyteidl/clients/go/admin/token_source_provider.go:119 +0x25
github.com/flyteorg/flyte/flyteidl/clients/go/admin.GetProxyTokenSource({0x2d1cc90, 0xc00133c6c0}, 0xdb6d77?)
	/go/src/github.com/flyteorg/flyteidl/clients/go/admin/auth_interceptor.go:59 +0x9d
github.com/flyteorg/flyte/flyteidl/clients/go/admin.MaterializeProxyAuthCredentials({0x2d1cc90?, 0xc00133c6c0?}, 0xc0003ce280, 0x2d1cc90?)
	/go/src/github.com/flyteorg/flyteidl/clients/go/admin/auth_interceptor.go:67 +0x3a
github.com/flyteorg/flyte/flyteidl/clients/go/admin.NewProxyAuthInterceptor.func1({0x2d1cc90, 0xc00133c6c0}, {0x2833b6c, 0x32}, {0x26400e0, 0xc0015c5440}, {0x25ff2c0, 0xc0005290c0}, 0x8?, 0x28f81b8, ...)
	/go/src/github.com/flyteorg/flyteidl/clients/go/admin/auth_interceptor.go:165 +0xe6
...
github.com/flyteorg/flyte/flyteidl/gen/pb-go/flyteidl/service.(*adminServiceClient).CreateWorkflowEvent(0xc00098d228, {0x2d1ccc8, 0xc0025848d0}, 0xc00065ebd0?, {0x0, 0x0, 0x0})
	/go/src/github.com/flyteorg/flyteidl/gen/pb-go/flyteidl/service/admin.pb.go:576 +0xc9

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (da77476) 59.04% compared to head (919764d) 78.48%.

❗ Current head 919764d differs from pull request most recent head 94daddb. Consider uploading reports for the commit 94daddb to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #4216       +/-   ##
===========================================
+ Coverage   59.04%   78.48%   +19.43%     
===========================================
  Files         621       18      -603     
  Lines       53091     1250    -51841     
===========================================
- Hits        31348      981    -30367     
+ Misses      19244      212    -19032     
+ Partials     2499       57     -2442     
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
flyteidl/clients/go/admin/client.go 86.91% <100.00%> (ø)
flyteidl/clients/go/admin/config.go 50.00% <ø> (ø)
flyteidl/clients/go/admin/config_flags.go 61.22% <ø> (ø)
...dl/clients/go/admin/pkce/auth_flow_orchestrator.go 63.04% <100.00%> (ø)
...eidl/clients/go/admin/pkce/handle_app_call_back.go 93.93% <100.00%> (ø)
flyteidl/clients/go/admin/auth_interceptor.go 71.42% <75.00%> (ø)

... and 633 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fg91
Copy link
Member

fg91 commented Oct 13, 2023

#4217 fixes the error you reported. Shell we close this PR here?

Thanks for reporting the issue and sorry about it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants