Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Don't drop stack traces #4248

Open
2 tasks done
iirekm opened this issue Oct 17, 2023 · 1 comment
Open
2 tasks done

[BUG] Don't drop stack traces #4248

iirekm opened this issue Oct 17, 2023 · 1 comment
Labels
backlogged For internal use. Reserved for contributor team workflow. bug Something isn't working

Comments

@iirekm
Copy link

iirekm commented Oct 17, 2023

Describe the bug

In pyflyte run ... I'm getting:

Encountered error while executing workflow ...:
  Error encountered while executing 'train':
  isinstance() arg 2 must be a type, a tuple of types, or a union

Dropping stack traces from console logs is an anti-pattern, making debugging very hard.

Ugly workaround (possible only on local machine): to WorkflowBase.__call__'s except block add:

            import traceback
            print(traceback.format_exc())

Flytekit version: 1.9.0

Expected behavior

Full stack trace should be preserved.

Additional context to reproduce

No response

Screenshots

No response

Are you sure this issue hasn't been raised already?

  • Yes

Have you read the Code of Conduct?

  • Yes
@iirekm iirekm added bug Something isn't working untriaged This issues has not yet been looked at by the Maintainers labels Oct 17, 2023
@eapolinario eapolinario added backlogged For internal use. Reserved for contributor team workflow. and removed untriaged This issues has not yet been looked at by the Maintainers labels Oct 19, 2023
@RRap0so
Copy link
Contributor

RRap0so commented Nov 3, 2023

@eapolinario gave it a shot. PTAL :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlogged For internal use. Reserved for contributor team workflow. bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants