Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] document cuda and requirements.txt imagespec features #4457

Closed
2 tasks done
Tracked by #5783
samhita-alla opened this issue Nov 20, 2023 · 10 comments
Closed
2 tasks done
Tracked by #5783

[Docs] document cuda and requirements.txt imagespec features #4457

samhita-alla opened this issue Nov 20, 2023 · 10 comments
Assignees
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers hacktoberfest pri1

Comments

@samhita-alla
Copy link
Contributor

Description

support for cuda has been added in flyteorg/flytekit#1688 PR and requirements.txt in flyteorg/flytekit#1698 PR. need to document these changes in the imagespec docs.

Are you sure this issue hasn't been raised already?

  • Yes

Have you read the Code of Conduct?

  • Yes
@samhita-alla samhita-alla added documentation Improvements or additions to documentation pri1 labels Nov 20, 2023
@davidmirror-ops
Copy link
Contributor

I think CUDA is already covered. In general, I think what's missing is to cover the supported config parameters in the main ImageSpec docs page

@sharsha315
Copy link

Hi, I would like to work on this issue. Can you please assign this issue. Thank you.

@sharsha315
Copy link

Hi @samhita-alla, I am sorry for late reply. Could you please, help me with more information to go further, because I see from the conserations above that some part of the issue is covered. What part of the issue that need to be worked on?. Thanks for the support.

@samhita-alla
Copy link
Contributor Author

this should clarify what you should be working on: #4457 (comment). is anything unclear? @sharsha315

@sharsha315
Copy link

Hi @samhita-alla, I am not able to build the docs locally in order to check the changes made, please, can you help me this.

@davidmirror-ops
Copy link
Contributor

@sharsha315 you should be able to build the docs locally by doing
make -C <path-to-your-fork>/docs html

@sharsha315
Copy link

Hi @samhita-alla, @davidmirror-ops, I have submitted the PR, please review the PR and provide feedback. Thank you.

@samhita-alla
Copy link
Contributor Author

@sharsha315
Copy link

Ok. Thank you for this opportunity.

@davidmirror-ops
Copy link
Contributor

@sharsha315 we'll close this one (sorry about that) but please submit the form as your intent to contribute still counts: https://tally.so/r/mJJ14r

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers hacktoberfest pri1
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants