-
Notifications
You must be signed in to change notification settings - Fork 671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Docs] document cuda and requirements.txt imagespec features #4457
Comments
I think CUDA is already covered. In general, I think what's missing is to cover the supported config parameters in the main ImageSpec docs page |
Hi, I would like to work on this issue. Can you please assign this issue. Thank you. |
Hi @samhita-alla, I am sorry for late reply. Could you please, help me with more information to go further, because I see from the conserations above that some part of the issue is covered. What part of the issue that need to be worked on?. Thanks for the support. |
this should clarify what you should be working on: #4457 (comment). is anything unclear? @sharsha315 |
Hi @samhita-alla, I am not able to build the docs locally in order to check the changes made, please, can you help me this. |
@sharsha315 you should be able to build the docs locally by doing |
Hi @samhita-alla, @davidmirror-ops, I have submitted the PR, please review the PR and provide feedback. Thank you. |
@davidmirror-ops looks like this isn't required anymore: https://github.com/flyteorg/flytekit/blob/00e9a794ca2011f0af4c149826063f4087082667/flytekit/image_spec/default_builder.py#L121-L132. we may need to close this issue. so sorry @sharsha315! |
Ok. Thank you for this opportunity. |
@sharsha315 we'll close this one (sorry about that) but please submit the form as your intent to contribute still counts: https://tally.so/r/mJJ14r Thank you |
Description
support for cuda has been added in flyteorg/flytekit#1688 PR and requirements.txt in flyteorg/flytekit#1698 PR. need to document these changes in the imagespec docs.
Are you sure this issue hasn't been raised already?
Have you read the Code of Conduct?
The text was updated successfully, but these errors were encountered: