remove hardcoded list of tests #4521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Samhita Alla <[email protected]>
dosubot
bot
added
the
size:M
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4521 +/- ##
==========================================
- Coverage 58.92% 58.91% -0.02%
==========================================
Files 620 620
Lines 52432 52432
==========================================
- Hits 30896 30890 -6
- Misses 19071 19077 +6
Partials 2465 2465
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
pingsutw
previously approved these changes
Dec 4, 2023
eapolinario
previously approved these changes
Dec 6, 2023
Signed-off-by: Samhita Alla <[email protected]>
samhita-alla
dismissed stale reviews from eapolinario and pingsutw
via
4698045
Signed-off-by: Samhita Alla <[email protected]>
Signed-off-by: Samhita Alla <[email protected]>
Signed-off-by: Samhita Alla <[email protected]>
Signed-off-by: Samhita Alla <[email protected]>
eapolinario
approved these changes
Dec 7, 2023
pvditt
pushed a commit
that referenced
this pull request
Dec 13, 2023
* remove hardcoded list of tests Signed-off-by: Samhita Alla <[email protected]> * latest version Signed-off-by: Samhita Alla <[email protected]> * latest version Signed-off-by: Samhita Alla <[email protected]> * add sensor Signed-off-by: Samhita Alla <[email protected]> * add flytesnacks to the path Signed-off-by: Samhita Alla <[email protected]> * add flytesnacks to the path Signed-off-by: Samhita Alla <[email protected]> --------- Signed-off-by: Samhita Alla <[email protected]> Co-authored-by: Eduardo Apolinario <[email protected]> Signed-off-by: Paul Dittamo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
https://github.com/flyteorg/flyte/issues/
Why are the changes needed?
whenever test names are modified, it necessitates updating the hardcoded list of tests in the flyte repo.
What changes were proposed in this pull request?
this PR removes the fixed list of tests and reads them from the latest flytesnacks release.
How was this patch tested?
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link