Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core feature] Support Multi-Thread execution in Local Execution #4601

Open
2 tasks done
ericwudayi opened this issue Dec 15, 2023 · 3 comments
Open
2 tasks done

[Core feature] Support Multi-Thread execution in Local Execution #4601

ericwudayi opened this issue Dec 15, 2023 · 3 comments
Assignees
Labels
enhancement New feature or request waiting for reporter Used for when we need input from the bug reporter

Comments

@ericwudayi
Copy link

Motivation: Why do you think this is important?

Local execution supports chaining in flyteorg/flytekit#1917. Supporting multi-thread execution can accelerate the total execution time, and it is possible very useful for future hybrid mode execution mentioned in #4205.

Goal: What should the final outcome look like, ideally?

If user define the chain of execution, local execution can support multi-thread execution. The final outcome should be exactly the same with current outcome but with much faster execution time.

Describe alternatives you've considered

NA

Propose: Link/Inline OR Additional context

@task
def t1(a:int) -> int:
    return a + 1

@task
def t2(a: int) -> int:
    return a + 2

@task 
def t3(a: int) ->int:
  return a + 3


## a3 and a1 can execute in the same time. and a2 execute only when a1 is complete.
@workflow
def wf(a: int)-> int:
   a1 = t1(a)
   a2 = t2(a1)
   a3 = t3(a)
   a1 >> a2
   a3

Are you sure this issue hasn't been raised already?

  • Yes

Have you read the Code of Conduct?

  • Yes
@ericwudayi ericwudayi added enhancement New feature or request untriaged This issues has not yet been looked at by the Maintainers labels Dec 15, 2023
Copy link

welcome bot commented Dec 15, 2023

Thank you for opening your first issue here! 🛠

Copy link

dosubot bot commented Dec 15, 2023

🤖

That's a great idea! Supporting multi-thread execution in local execution can definitely accelerate the total execution time and be very useful for future hybrid mode execution. Your proposed solution and motivation are clear and well thought out. We encourage you to go ahead and create a pull request for this feature. Your contribution will be valuable to the flyte community. Thank you for your interest in improving flyte!


This response is meant to be useful and save you time. It is not meant to be a precise solution, but rather a starting point for your own research.

Help me be more useful! Please leave a 👍 if this is helpful and 👎 if it is irrelevant.

If you want to continue the conversation, start your reply with @dosu-bot.

@eapolinario
Copy link
Contributor

@ericwudayi , this feature has the potential for increasing the utility of local executions tremendously. How about we turn this into an RFC? Can you initiate a discussion in https://github.com/flyteorg/flyte/discussions/categories/rfc-incubator ?

@eapolinario eapolinario added waiting for reporter Used for when we need input from the bug reporter and removed untriaged This issues has not yet been looked at by the Maintainers labels Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request waiting for reporter Used for when we need input from the bug reporter
Projects
None yet
Development

No branches or pull requests

2 participants