Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Flyte Makefile missing / in mv command #4639

Closed
2 tasks done
shubhscoder opened this issue Dec 24, 2023 · 2 comments · Fixed by #4648
Closed
2 tasks done

[BUG] Flyte Makefile missing / in mv command #4639

shubhscoder opened this issue Dec 24, 2023 · 2 comments · Fixed by #4648
Labels
bug Something isn't working

Comments

@shubhscoder
Copy link

Describe the bug

In flyte/Makefile

.PHONY: compile
compile: cmd/single/dist
	go build -tags console -v -o flyte -ldflags=$(LD_FLAGS) ./cmd/
	mv ./flyte ${GOPATH}/bin || echo "Skipped copying 'flyte' to ${GOPATH}/bin"

The mv command does not have a '/' after bin. As a result of this if there is no folder bin in GOPATH, then flyte binary will be moved in GOPATH and renamed to bin, which is incorrect.

Expected behavior

The flyte binary should move inside ${GOPATH}/bin/ without getting renamed to bin

Additional context to reproduce

Run make compile in flyte folder.

Screenshots

No response

Are you sure this issue hasn't been raised already?

  • Yes

Have you read the Code of Conduct?

  • Yes
@shubhscoder shubhscoder added bug Something isn't working untriaged This issues has not yet been looked at by the Maintainers labels Dec 24, 2023
Copy link

welcome bot commented Dec 24, 2023

Thank you for opening your first issue here! 🛠

Copy link

dosubot bot commented Dec 24, 2023

🤖

Thank you for bringing this to our attention! It's great to see users like you taking an interest in improving the Flyte platform. Your proposed fix makes sense, and we encourage you to go ahead and create a pull request with the necessary changes. Your contribution will be much appreciated by the Flyte community. Keep up the good work!


This response is meant to be useful and save you time. It is not meant to be a precise solution, but rather a starting point for your own research.

Help me be more useful! Please leave a 👍 if this is helpful and 👎 if it is irrelevant.

If you want to continue the conversation, start your reply with @dosu-bot.

@eapolinario eapolinario removed the untriaged This issues has not yet been looked at by the Maintainers label Dec 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants