Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Registration somehow tries to parse the git directory itself #4652

Open
2 tasks done
wild-endeavor opened this issue Dec 29, 2023 · 3 comments
Open
2 tasks done
Labels
backlogged For internal use. Reserved for contributor team workflow. bug Something isn't working flytekit FlyteKit Python related issue

Comments

@wild-endeavor
Copy link
Contributor

Describe the bug

https://flyte-org.slack.com/archives/CP2HDHKE1/p1703729465162729

and potentially others?

Expected behavior

the correct behavior.

Additional context to reproduce

see thread. sample repo was https://github.com/gone2808/flyte-train

Screenshots

No response

Are you sure this issue hasn't been raised already?

  • Yes

Have you read the Code of Conduct?

  • Yes
@wild-endeavor wild-endeavor added bug Something isn't working untriaged This issues has not yet been looked at by the Maintainers labels Dec 29, 2023
Copy link

welcome bot commented Dec 29, 2023

Thank you for opening your first issue here! 🛠

Copy link

dosubot bot commented Dec 29, 2023

🤖

Hello @wild-endeavor! 👋 I'm Dosu, a friendly bot here to help you while we wait for human maintainers. I can assist you with bugs, answer your questions, and guide you on becoming a contributor. So, while we're waiting for them, let's see what we can do together!

Based on the information provided, it's not entirely clear what the exact error message or issue is when the registration tries to parse the git directory. Could you please provide more details about the error message or the behavior you're experiencing? This will help in diagnosing the issue more accurately.

Regarding the registration process in the Flyte codebase, it's handled through GitHub Actions, as defined in the provided YAML file. This process involves several steps, including generating git tags, building Docker images, publishing Flyte binary and component images, releasing Helm charts, and releasing manifests. The interaction with git directories is mainly through the 'actions/checkout' action, which checks out the repository's code into the GitHub Actions runner's workspace. This allows subsequent steps in the workflow to operate on the codebase. The 'git.createRef' function is used to create new git tags in the repository. You can find more details in the .github/workflows/create_release.yml file.

As for the https://github.com/gone2808/flyte-train repository, without more specific information about its configuration or setup, it's difficult to determine if there's anything in it that could be causing this issue.

Lastly, without more details about the error or issue, it's hard to say how the Flyte codebase handles parsing of git directories during the registration process, or if there are any known issues or bugs in the 'actions/checkout' action or the 'git.createRef' function that could be causing this issue.

Please provide more details about the error message or issue, and any specific configuration or setup in the https://github.com/gone2808/flyte-train repository. This will help in diagnosing and resolving the issue more effectively.

Sources


This response is meant to be useful and save you time. It is not meant to be a precise solution, but rather a starting point for your own research.

Help me be more useful! Please leave a 👍 if this is helpful and 👎 if it is irrelevant.

If you want to continue the conversation, start your reply with @dosu-bot.

@wild-endeavor wild-endeavor added the flytekit FlyteKit Python related issue label Dec 29, 2023
@gone2808
Copy link

gone2808 commented Jan 1, 2024

shortly problem
pyflyte register ./ is detected root as the previous folder(/mnt/data1/hainq) which will make the timeout if the parent folder has a large file.
pyflyte register ./ should detect root as current pwd folder(mnt/data1/hainq/flyte-train)
image

@eapolinario eapolinario added backlogged For internal use. Reserved for contributor team workflow. and removed untriaged This issues has not yet been looked at by the Maintainers labels Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlogged For internal use. Reserved for contributor team workflow. bug Something isn't working flytekit FlyteKit Python related issue
Projects
None yet
Development

No branches or pull requests

3 participants