Fix read cache by delegating to uncached client #4748
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hongxin Liang <[email protected]>
honnix
force-pushed
the
fix-read-cache
branch
from
ab70c1d to
77a16fb
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #4748 +/- ##
=======================================
Coverage 58.18% 58.18%
=======================================
Files 626 626
Lines 53833 53830 -3
=======================================
Hits 31322 31322
+ Misses 20003 20000 -3
Partials 2508 2508
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Closing in favour of #4752 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
Why are the changes needed?
This PR tries to solve a problem in #4733 where cache lookup would be delegated forever in case of a cache miss.
Note that this PR does not try to address the missing writethrough cache which got removed by #4199. If that feature is still needed, we should bring it back (tried that in honnix#2).
What changes were proposed in this pull request?
Use an uncached client as a fallback to avoid endless cache lookup.
How was this patch tested?
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link