Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small formatting fixes for Databrick agents docs #4758

Merged
merged 2 commits into from
Jan 23, 2024

Conversation

neverett
Copy link
Contributor

@neverett neverett commented Jan 22, 2024

Why are the changes needed?

I introduced a few small formatting issues in #4008; this PR fixes them.

What changes were proposed in this pull request?

  • Agents index page - fix link to Databricks Agent doc
  • MMCloud Agent page - fix formatting of last line

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

#4751

Docs link

https://flyte--4758.org.readthedocs.build/en/4758/deployment/agents/index.html

https://flyte--4758.org.readthedocs.build/en/4758/deployment/agents/mmcloud.html#upgrade-the-deployment

nikki everett added 2 commits January 22, 2024 13:23
Signed-off-by: nikki everett <[email protected]>
@neverett neverett requested review from ppiegaze and pingsutw January 22, 2024 19:31
@neverett neverett self-assigned this Jan 22, 2024
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. documentation Improvements or additions to documentation labels Jan 22, 2024
Copy link

codecov bot commented Jan 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5300e1b) 58.17% compared to head (6853e9e) 58.18%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4758      +/-   ##
==========================================
+ Coverage   58.17%   58.18%   +0.01%     
==========================================
  Files         626      626              
  Lines       53833    53833              
==========================================
+ Hits        31315    31322       +7     
+ Misses      20010    20003       -7     
  Partials     2508     2508              
Flag Coverage Δ
unittests 58.18% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 22, 2024
@Future-Outlier Future-Outlier merged commit ca73251 into master Jan 23, 2024
45 checks passed
@Future-Outlier Future-Outlier deleted the docs/fix-databricks-agent-link branch January 23, 2024 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants