-
Notifications
You must be signed in to change notification settings - Fork 671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Leverage KubeRay v1 instead of v1alpha1 for resources #4818
Conversation
Thank you for opening this pull request! 🙌 These tips will help get your PR across the finish line:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a few tests to ray_test.go
?
@eapolinario I noticed the build failed due to it "being cancelled". Is this expected? Is there a way to test and ensure everything is good to go through the CI? Thanks! |
Thanks for adding tests! I just approved the CI checks (they are setup in such a way that maintainers have to manually approve for them to run). |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #4818 +/- ##
==========================================
- Coverage 59.51% 58.91% -0.61%
==========================================
Files 645 645
Lines 51891 55351 +3460
==========================================
+ Hits 30883 32609 +1726
- Misses 18435 20159 +1724
- Partials 2573 2583 +10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@eapolinario can we try triggering these again? Had to push a couple fixes up. Also, let me know if this is ready to go! |
@peterghaddad , can you merge master (to get rid of the docs error) and sign DCO? The change itself looks good, but we need fix those before merging. |
@eapolinario signed off and merged master! |
@eapolinario no rush, but politely wanted to follow up on this! |
Congrats on merging your first pull request! 🎉 |
* initial * Clean up * init * Clean up * Add TestGetEventInfo_LogTemplatesV1 * Add more tests * Fix tests * Remove dupe * Fix lint * add comment Signed-off-by: peterghaddad <[email protected]> --------- Signed-off-by: peterghaddad <[email protected]> Co-authored-by: Neil <[email protected]> Signed-off-by: Katrina Rogan <[email protected]>
* initial * Clean up * init * Clean up * Add TestGetEventInfo_LogTemplatesV1 * Add more tests * Fix tests * Remove dupe * Fix lint * add comment Signed-off-by: peterghaddad <[email protected]> --------- Signed-off-by: peterghaddad <[email protected]> Co-authored-by: Neil <[email protected]>
Tracking issue
#4802
Closes #4802
Why are the changes needed?
The new API version for the Ray Job CRD enables further customization. This will benefit future issues, and will ensure that people are using the latest and greatest API versions. We will still support v1alpha1 and will default to it in the configuration so there are no interruptions to the community.
What changes were proposed in this pull request?
Add config option to choose between using KubeRay CRD versions.
Add KubeRay v1 as an option for creating KubeRay Jobs.
How was this patch tested?
Through unit tests.
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link