Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Housekeeping] Add functional test with reasonable ephemeral storage requests in task #4942

Closed
2 tasks done
katrogan opened this issue Feb 23, 2024 · 2 comments
Closed
2 tasks done
Assignees
Labels
enhancement New feature or request housekeeping Issues that help maintain flyte and keep it tech-debt free

Comments

@katrogan
Copy link
Contributor

Describe the issue

We should have functional tests to catch scenarios where we check in impractically low request defaults and limits, like in #4782

What if we do not do this?

Rely on code review to catch issues

Related component(s)

No response

Are you sure this issue hasn't been raised already?

  • Yes

Have you read the Code of Conduct?

  • Yes
@katrogan katrogan added the housekeeping Issues that help maintain flyte and keep it tech-debt free label Feb 23, 2024
Copy link

dosubot bot commented Feb 23, 2024

🤖

It's great to see your interest in adding functional tests to catch scenarios with impractically low request defaults and limits. Your contribution will definitely help improve the reliability and robustness of the codebase. If you have a proposed solution or fix in mind, we encourage you to go ahead and create a pull request. Your efforts will be much appreciated!

About Dosu

This response is meant to be useful and save you time. It is not meant to be a precise solution, but rather a starting point for your own research.

Help me be more useful! Please leave a 👍 if this is helpful and 👎 if it is irrelevant.

If you want to continue the conversation, start your reply with @dosu-bot.

@dosubot dosubot bot added the enhancement New feature or request label Feb 23, 2024
@katrogan
Copy link
Contributor Author

katrogan commented Mar 5, 2024

done flyteorg/flytesnacks#1543

@katrogan katrogan closed this as completed Mar 5, 2024
@katrogan katrogan self-assigned this Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request housekeeping Issues that help maintain flyte and keep it tech-debt free
Projects
None yet
Development

No branches or pull requests

1 participant