Add k8s env froms

[neilisaur]

Tracking issue

Closes #4968

Why are the changes needed?

We are able to specify default environment variables through the k8s plugin, but only those hard-coded into the configuration. Allowing default environment variables to be set via configMap or secret would allow automated systems in our environment to access secrets without embedding them in multiple locations.

What changes were proposed in this pull request?

Add ability to specify default configMap and secrets to mount on k8s plugin tasks.

How was this patch tested?

Unit tested, but local builds could not emulate the propeller build process currently.

Setup process

Screenshots

Check all the applicable boxes

• I updated the documentation accordingly.
• All new and existing tests passed.
• All commits are signed-off.

[codecov]

Codecov Report

Attention: Patch coverage is 37.50000% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 58.99%. Comparing base (3100c12) to head (bc6b254).

Files	Patch %	Lines
...asks/pluginmachinery/flytek8s/k8s_resource_adds.go	28.57%	8 Missing and 2 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #4969      +/-   ##
==========================================
+ Coverage   58.97%   58.99%   +0.01%     
==========================================
  Files         645      645              
  Lines       55578    55590      +12     
==========================================
+ Hits        32778    32794      +16     
+ Misses      20207    20202       -5     
- Partials     2593     2594       +1     

Flag	Coverage Δ
unittests	58.99% <37.50%> (+0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[eapolinario]

We need a little bit more work to load configmaps and secrets.

[eapolinario]

@neilisaur , can you fix the lint error and merge master while you're at it?

[neilisaur]

@neilisaur , can you fix the lint error and merge master while you're at it?

@eapolinario done and done! Re-ran make helm as well

[neilisaur]

@eapolinario for the Chart version update that's failing is there a specific method of changing it, or should I just update everything under charts/ to v0.1.11?

[eapolinario]

@neilisaur , don't worry about that CI check failure. We've started to validate changes to the helm charts only recently, which means that we shouldn't be blocking PRs using those checks yet.

[eapolinario]

Thanks you for your contribution!

[flixr]

@neilisaur @eapolinario seems this broke tasks which already have env_from set in the pod template!
My secrets from the pod template are not there anymore... had to roll back to flyte 1.11.

I have a pod template something like:

primary_container = V1Container(name="primary")
primary_container.env_from = [V1EnvFromSource(secret_ref=V1SecretEnvSource(name="my-secret"))]
ps = V1PodSpec(containers=[primary_container])
pod_template = PodTemplate(pod_spec=ps, primary_container_name="primary")