Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add org as an optional request param to dataproxy CreateUploadLocation #5060

Merged
merged 2 commits into from
Mar 18, 2024

Conversation

katrogan
Copy link
Contributor

@katrogan katrogan commented Mar 15, 2024

Tracking issue

#4588

Why are the changes needed?

What changes were proposed in this pull request?

How was this patch tested?

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. enhancement New feature or request labels Mar 15, 2024
Copy link

codecov bot commented Mar 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.99%. Comparing base (3100c12) to head (b1c8a1b).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5060      +/-   ##
==========================================
+ Coverage   58.97%   58.99%   +0.01%     
==========================================
  Files         645      645              
  Lines       55578    55578              
==========================================
+ Hits        32778    32789      +11     
+ Misses      20207    20198       -9     
+ Partials     2593     2591       -2     
Flag Coverage Δ
unittests 58.99% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Katrina Rogan <[email protected]>
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:XL This PR changes 500-999 lines, ignoring generated files. labels Mar 15, 2024
@katrogan
Copy link
Contributor Author

PTAL @eapolinario @pingsutw @hamersaw

@katrogan
Copy link
Contributor Author

friendly ping @hamersaw @eapolinario

@katrogan katrogan merged commit 9818423 into master Mar 18, 2024
48 checks passed
@katrogan katrogan deleted the create-upload-location-org branch March 18, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants