Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core feature] Create helm chart for Spark serviceaccount files #5061

Open
2 tasks done
MortalHappiness opened this issue Mar 15, 2024 · 4 comments
Open
2 tasks done
Labels
enhancement New feature or request helm

Comments

@MortalHappiness
Copy link
Member

Motivation: Why do you think this is important?

In the Configure Kubernetes Plugins documentation, it says that when configuring the Spark plugin, we need to create 4 yaml files and apply them manually. These steps are tedious when we try to develop Spark-related features locally.

Goal: What should the final outcome look like, ideally?

Instead of creating 4 yaml files and executing kubectl apply for each of them, create a helm chart for these four files so we can simply execute helm install when we want to develop Spark-related features locally.

Describe alternatives you've considered

N/A

Propose: Link/Inline OR Additional context

No response

Are you sure this issue hasn't been raised already?

  • Yes

Have you read the Code of Conduct?

  • Yes
@MortalHappiness MortalHappiness added enhancement New feature or request untriaged This issues has not yet been looked at by the Maintainers labels Mar 15, 2024
Copy link

dosubot bot commented Mar 15, 2024

It's great to see your interest in improving the development experience for Spark-related features. Creating a helm chart for the service account files sounds like a valuable addition. Your contribution would definitely make it easier for developers to work with Spark locally. Thank you for considering this enhancement!

About Dosu

This response is meant to be useful and save you time. It is not meant to be a precise solution, but rather a starting point for your own research.

Help me be more useful! Please leave a 👍 if this is helpful and 👎 if it is irrelevant.

If you want to continue the conversation, start your reply with @dosu-bot.

@Future-Outlier
Copy link
Member

+1, we need this

@pingsutw
Copy link
Member

+1, feel free to open a PR

@pingsutw pingsutw added helm and removed untriaged This issues has not yet been looked at by the Maintainers labels Mar 15, 2024
@davidmirror-ops
Copy link
Contributor

@MortalHappiness Thanks for surfacing this.
I don't think we need another chart for it tho. This week I was able to fold those settings (and found some errors in that page) into the cluster_resource_templates section on flyte-core, and it works.
I'll be sending a PR adding you as reviewer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request helm
Projects
None yet
Development

No branches or pull requests

4 participants