-
Notifications
You must be signed in to change notification settings - Fork 670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Core feature] Add new config to disable fallback to container task handler #5076
Comments
#take |
It seems like you've got this under control, if you want help or have specific questions, let me know what I can do for you!
|
Resolves: flyteorg#5076 Signed-off-by: Chi-Sheng Liu <[email protected]>
Resolves: flyteorg#5076 Signed-off-by: Chi-Sheng Liu <[email protected]>
…andler Resolves: flyteorg#5076 Signed-off-by: Chi-Sheng Liu <[email protected]>
@MortalHappiness , before we consider this more seriously, can you talk about your use case a bit more? |
@eapolinario For example, if we create a Ray task and forget to install the Ray operator, it will fallback to use the container handler to run the task, which seems to be fine and the result is correct. However, no matter how many replicas you specified in your task, there will be only one container because the task is run as a container task instead of a Ray task. |
…andler Resolves: flyteorg#5076 Signed-off-by: Chi-Sheng Liu <[email protected]>
… handler Resolves: flyteorg#5076 Signed-off-by: Chi-Sheng Liu <[email protected]>
… handler Resolves: flyteorg#5076 Signed-off-by: Chi-Sheng Liu <[email protected]>
… handler Resolves: flyteorg#5076 Signed-off-by: Chi-Sheng Liu <[email protected]>
… handler Resolves: flyteorg#5076 Signed-off-by: Chi-Sheng Liu <[email protected]>
… handler Resolves: flyteorg#5076 Signed-off-by: Chi-Sheng Liu <[email protected]>
… handler Resolves: flyteorg#5076 Signed-off-by: Chi-Sheng Liu <[email protected]>
… handler Resolves: flyteorg#5076 Signed-off-by: Chi-Sheng Liu <[email protected]>
Motivation: Why do you think this is important?
If a task does not have a registered plugin handler, it will fallback to the container task handler. We usually do not want this behavior and expect the task without the corresponding task handlers to fail directly.
Goal: What should the final outcome look like, ideally?
Add a new config to allow users to prevent the default fallback task handler.
Describe alternatives you've considered
N/A
Propose: Link/Inline OR Additional context
No response
Are you sure this issue hasn't been raised already?
Have you read the Code of Conduct?
The text was updated successfully, but these errors were encountered: