Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core feature] Add new config to disable fallback to container task handler #5076

Open
2 tasks done
MortalHappiness opened this issue Mar 19, 2024 · 4 comments · May be fixed by #5077
Open
2 tasks done

[Core feature] Add new config to disable fallback to container task handler #5076

MortalHappiness opened this issue Mar 19, 2024 · 4 comments · May be fixed by #5077
Assignees
Labels
enhancement New feature or request propeller Issues related to flyte propeller waiting for reporter Used for when we need input from the bug reporter

Comments

@MortalHappiness
Copy link
Member

MortalHappiness commented Mar 19, 2024

Motivation: Why do you think this is important?

If a task does not have a registered plugin handler, it will fallback to the container task handler. We usually do not want this behavior and expect the task without the corresponding task handlers to fail directly.

Goal: What should the final outcome look like, ideally?

Add a new config to allow users to prevent the default fallback task handler.

Describe alternatives you've considered

N/A

Propose: Link/Inline OR Additional context

No response

Are you sure this issue hasn't been raised already?

  • Yes

Have you read the Code of Conduct?

  • Yes
@MortalHappiness MortalHappiness added enhancement New feature or request untriaged This issues has not yet been looked at by the Maintainers labels Mar 19, 2024
@MortalHappiness
Copy link
Member Author

#take

Copy link

dosubot bot commented Mar 19, 2024

It seems like you've got this under control, if you want help or have specific questions, let me know what I can do for you!

About Dosu

This response is meant to be useful and save you time. It is not meant to be a precise solution, but rather a starting point for your own research.

Help me be more useful! Please leave a 👍 if this is helpful and 👎 if it is irrelevant.

If you want to continue the conversation, start your reply with @dosu-bot.

@MortalHappiness MortalHappiness changed the title [Core feature] Add new config: prevent fallback task handler [Core feature] Add new config: prevent default container task handler Mar 19, 2024
MortalHappiness added a commit to MortalHappiness/flyte that referenced this issue Mar 19, 2024
MortalHappiness added a commit to MortalHappiness/flyte that referenced this issue Mar 19, 2024
MortalHappiness added a commit to MortalHappiness/flyte that referenced this issue Mar 19, 2024
@MortalHappiness MortalHappiness changed the title [Core feature] Add new config: prevent default container task handler [Core feature] Add new config to disable fallback to container task handler Mar 19, 2024
@pingsutw pingsutw added propeller Issues related to flyte propeller and removed untriaged This issues has not yet been looked at by the Maintainers labels Mar 21, 2024
@eapolinario
Copy link
Contributor

@MortalHappiness , before we consider this more seriously, can you talk about your use case a bit more?

@eapolinario eapolinario added the waiting for reporter Used for when we need input from the bug reporter label Mar 21, 2024
@MortalHappiness
Copy link
Member Author

MortalHappiness commented Mar 22, 2024

@eapolinario For example, if we create a Ray task and forget to install the Ray operator, it will fallback to use the container handler to run the task, which seems to be fine and the result is correct. However, no matter how many replicas you specified in your task, there will be only one container because the task is run as a container task instead of a Ray task.

MortalHappiness added a commit to MortalHappiness/flyte that referenced this issue Mar 27, 2024
MortalHappiness added a commit to MortalHappiness/flyte that referenced this issue Mar 28, 2024
MortalHappiness added a commit to MortalHappiness/flyte that referenced this issue Mar 28, 2024
MortalHappiness added a commit to MortalHappiness/flyte that referenced this issue Mar 29, 2024
MortalHappiness added a commit to MortalHappiness/flyte that referenced this issue Apr 2, 2024
MortalHappiness added a commit to MortalHappiness/flyte that referenced this issue Apr 4, 2024
MortalHappiness added a commit to MortalHappiness/flyte that referenced this issue Apr 9, 2024
MortalHappiness added a commit to MortalHappiness/flyte that referenced this issue May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request propeller Issues related to flyte propeller waiting for reporter Used for when we need input from the bug reporter
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants