Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Core feature] Allow setting a ExecutionClusterLabel when triggering a Launchplan/Workflow/Task #5081

Closed
2 tasks done
RRap0so opened this issue Mar 20, 2024 · 1 comment · Fixed by #4998
Closed
2 tasks done

[Core feature] Allow setting a ExecutionClusterLabel when triggering a Launchplan/Workflow/Task #5081

RRap0so opened this issue Mar 20, 2024 · 1 comment · Fixed by #4998
Assignees
@RRap0so
Labels
enhancement New feature or request

Comments

@RRap0so
Copy link
Contributor

RRap0so commented Mar 20, 2024

Motivation: Why do you think this is important?

This is important to allow folks direct traffic to specific clusters. This was an alternative approach to #4956

This way users should be able to select cluster execution to a cluster of their choosing

Goal: What should the final outcome look like, ideally?

This will help folks that want to select what clusters to execute things without being tied to a Project/Domain.

Describe alternatives you've considered

See #4956

Propose: Link/Inline OR Additional context

#4998

Are you sure this issue hasn't been raised already?

  • Yes

Have you read the Code of Conduct?

  • Yes
@RRap0so RRap0so added enhancement New feature or request untriaged This issues has not yet been looked at by the Maintainers labels Mar 20, 2024
@dosubot DosuBot
Copy link

dosubot bot commented Mar 20, 2024 •
edited
Loading

It's great to see your interest in contributing to the repository! Your proposed feature sounds like it could be really valuable for users. Encouraging users to select specific clusters for execution without being tied to a Project/Domain is definitely a useful capability. I encourage you to go ahead and create a pull request for this feature if you haven't already. Your contribution will be appreciated by the maintainers. Keep up the good work!

About Dosu

This response is meant to be useful and save you time. It is not meant to be a precise solution, but rather a starting point for your own research.

Help me be more useful! Please leave a 👍 if this is helpful and 👎 if it is irrelevant.

If you want to continue the conversation, start your reply with @dosu-bot.

This was referenced Mar 20, 2024
Closed
Merged
wild-endeavor pushed a commit that referenced this issue Mar 25, 2024
@RRap0so
Allow setting a ExecutionClusterLabel when triggering a Launchplan/Wo…
2260ca2 
…rkflow/Task (#4998)

Add ExecutionClusterLabel to the ExecutionSpec so users can override the label at kick off time.

Closes #5081

Signed-off-by: Rafael Raposo <[email protected]>
@wild-endeavor wild-endeavor removed the untriaged This issues has not yet been looked at by the Maintainers label Mar 25, 2024
yubofredwang pushed a commit to yubofredwang/flyte that referenced this issue Mar 26, 2024
@RRap0so @yubofredwang
Allow setting a ExecutionClusterLabel when triggering a Launchplan/Wo…
e7548e0 
…rkflow/Task (flyteorg#4998)

Add ExecutionClusterLabel to the ExecutionSpec so users can override the label at kick off time.

Closes flyteorg#5081

Signed-off-by: Rafael Raposo <[email protected]>
@RRap0so RRap0so mentioned this issue May 20, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RRap0so RRap0so

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow setting a ExecutionClusterLabel when triggering a Launchplan/Workflow/Task RRap0so/flyte
2 participants
@wild-endeavor @RRap0so