-
Notifications
You must be signed in to change notification settings - Fork 669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Docs] Testing agents in the development environment #5106
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5106 +/- ##
==========================================
- Coverage 59.10% 58.60% -0.50%
==========================================
Files 645 568 -77
Lines 55574 51112 -4462
==========================================
- Hits 32846 29955 -2891
+ Misses 20135 18742 -1393
+ Partials 2593 2415 -178
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
f89dfbf
to
afcfd79
Compare
Hey @Future-Outlier sorry for the delay on reviewing this -- would you be able to add your changes from #5107 to this PR so the combined changes can be reviewed together? |
I've just merged it, thank you for reviewing this PR. |
Signed-off-by: Future-Outlier <[email protected]>
Signed-off-by: Future-Outlier <[email protected]>
Signed-off-by: Future-Outlier <[email protected]>
Signed-off-by: Future-Outlier <[email protected]>
Signed-off-by: Future-Outlier <[email protected]>
Signed-off-by: Future-Outlier <[email protected]>
Signed-off-by: Future-Outlier <[email protected]>
Signed-off-by: Future-Outlier <[email protected]> Co-authored-by: Kevin Su <[email protected]>
Signed-off-by: Future-Outlier <[email protected]> Co-authored-by: Kevin Su <[email protected]>
Signed-off-by: Future-Outlier <[email protected]>
Signed-off-by: Future-Outlier <[email protected]>
Signed-off-by: Future-Outlier <[email protected]>
Signed-off-by: Future-Outlier <[email protected]>
c8086c9
to
97cebbc
Compare
@neverett Hi, will you review these docs recently? |
@Future-Outlier sure thing, I can take a look today! |
@Future-Outlier would it be okay if I pushed commits to this branch? I think it will be faster for me to reorganize some of the information that way. |
it will be okay |
@neverett feel free to do that, thank you! |
Signed-off-by: nikki everett <[email protected]>
@Future-Outlier I pushed a commit to reorganize and edit the content -- let me know what you think! If my changes look good to you and tests are passing, feel free to merge. |
@neverett It's great, thank you! |
* Testing agents in the development environment Signed-off-by: Future-Outlier <[email protected]> * nit Signed-off-by: Future-Outlier <[email protected]> * nit Signed-off-by: Future-Outlier <[email protected]> * update Signed-off-by: Future-Outlier <[email protected]> * rename Signed-off-by: Future-Outlier <[email protected]> * blank Signed-off-by: Future-Outlier <[email protected]> * rerun build docs ci Signed-off-by: Future-Outlier <[email protected]> * update pingsu's advice Signed-off-by: Future-Outlier <[email protected]> Co-authored-by: Kevin Su <[email protected]> * Update pingsu's advice Signed-off-by: Future-Outlier <[email protected]> Co-authored-by: Kevin Su <[email protected]> * deploying agents in the sandbox Signed-off-by: Future-Outlier <[email protected]> * rename Signed-off-by: Future-Outlier <[email protected]> * nit Signed-off-by: Future-Outlier <[email protected]> * Implementing Agent Metadata Service Signed-off-by: Future-Outlier <[email protected]> * reorganize and copyedit new content Signed-off-by: nikki everett <[email protected]> --------- Signed-off-by: Future-Outlier <[email protected]> Signed-off-by: nikki everett <[email protected]> Co-authored-by: Kevin Su <[email protected]> Co-authored-by: nikki everett <[email protected]>
Docs link
index: https://flyte--5106.org.readthedocs.build/en/5106/flyte_agents/index.html
testing_agents_in_the_development_environment: https://flyte--5106.org.readthedocs.build/en/5106/flyte_agents/testing_agents_in_the_development_environment.html
deploying_agents_to_the_flyte_sandbox: https://flyte--5106.org.readthedocs.build/en/5106/flyte_agents/deploying_agents_to_the_flyte_sandbox.html
implementing_agent_metadata_service: https://flyte--5106.org.readthedocs.build/en/5106/flyte_agents/implementing_agent_metadata_service.html
Tracking issue
#3936
Why are the changes needed?
Help users to develop agent service and test it more easily.
What changes were proposed in this pull request?
Add
Testing agents in the development environment
documentation.How was this patch tested?
@samhita-alla has tested it when developing the aws sagemaker agent, and it works well
Setup process
Screenshots
Check all the applicable boxes
Related PRs
flyteorg/static-resources#37