-
Notifications
You must be signed in to change notification settings - Fork 671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Id bigint conversation for not yet created table #5157
Fix Id bigint conversation for not yet created table #5157
Conversation
Thank you for opening this pull request! 🙌 These tips will help get your PR across the finish line:
|
9aeeac3
to
f51755c
Compare
Signed-off-by: YiShengOng <[email protected]>
f51755c
to
5e78483
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5157 +/- ##
==========================================
+ Coverage 59.10% 59.11% +0.01%
==========================================
Files 645 645
Lines 55574 55574
==========================================
+ Hits 32846 32852 +6
+ Misses 20135 20129 -6
Partials 2593 2593
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Congrats on merging your first pull request! 🎉 |
Signed-off-by: YiShengOng <[email protected]>
Tracking issue
#3966
Why are the changes needed?
This commit fixes a bug with migrations. The previous code was modifying a table (
description_entities
) that does not exists yet when the migration is ran in order.What changes were proposed in this pull request?
Only modify id column of tables that exist already.
How was this patch tested?
N/A
Check all the applicable boxes