Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Id bigint conversation for not yet created table #5157

Conversation

ongkong
Copy link
Contributor

@ongkong ongkong commented Mar 30, 2024

Tracking issue

#3966

Why are the changes needed?

This commit fixes a bug with migrations. The previous code was modifying a table (description_entities) that does not exists yet when the migration is ran in order.

What changes were proposed in this pull request?

Only modify id column of tables that exist already.

How was this patch tested?

N/A

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Copy link

welcome bot commented Mar 30, 2024

Thank you for opening this pull request! 🙌

These tips will help get your PR across the finish line:

  • Most of the repos have a PR template; if not, fill it out to the best of your knowledge.
  • Sign off your commits (Reference: DCO Guide).

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. bug Something isn't working labels Mar 30, 2024
@ongkong ongkong changed the title Fix Id bigint conversation for not created table Fix Id bigint conversation for not yet created table Mar 30, 2024
@ongkong ongkong force-pushed the ongkong/fix-migration-big-int-conversion branch 3 times, most recently from 9aeeac3 to f51755c Compare March 30, 2024 16:39
@ongkong ongkong force-pushed the ongkong/fix-migration-big-int-conversion branch from f51755c to 5e78483 Compare March 30, 2024 16:40
Copy link

codecov bot commented Mar 31, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 59.11%. Comparing base (f5f8230) to head (5e78483).

Files Patch % Lines
flyteadmin/pkg/repositories/config/migrations.go 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5157      +/-   ##
==========================================
+ Coverage   59.10%   59.11%   +0.01%     
==========================================
  Files         645      645              
  Lines       55574    55574              
==========================================
+ Hits        32846    32852       +6     
+ Misses      20135    20129       -6     
  Partials     2593     2593              
Flag Coverage Δ
unittests 59.11% <33.33%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@eapolinario eapolinario left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Apr 4, 2024
@eapolinario eapolinario merged commit bcdbf5f into flyteorg:master Apr 4, 2024
47 of 48 checks passed
Copy link

welcome bot commented Apr 4, 2024

Congrats on merging your first pull request! 🎉

Jeinhaus pushed a commit to Jeinhaus/flyte that referenced this pull request Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants