-
Notifications
You must be signed in to change notification settings - Fork 671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] rshift '>>' operator doesn't work properly with remoteEntities #5393
Comments
cc @pingsutw |
The issue you are describing is related to the improper functioning of the Would you like more detail on how to work around this issue or any other specific aspect? Sources:
This is an AI-generated response and your feedback is appreciated! Please leave a 👍 if this is helpful and 👎 if it is not. Mention @RunLLM to ask follow-up questions. See runllm.com for more! |
@andresgomezfrr Could you provide an example like the one you have just mentioned?
|
I tested this again with the latest release and looks like it is working fine, I'm going to close this issue |
Describe the bug
The rshift
>>
operator doesn't work properly using remoteEntities. Even if you defineremote_entity_1 >> remote_entity_2
the upstream is not configured and both entities run in parallel.More context:
The stacktrace to create a remoteEntitiy is the following one:
https://github.com/flyteorg/flytekit/blob/master/flytekit/remote/remote_callable.py#L35 -->
https://github.com/flyteorg/flytekit/blob/master/flytekit/remote/remote_callable.py#L53 -->
https://github.com/flyteorg/flytekit/blob/master/flytekit/remote/remote_callable.py#L33 -->
https://github.com/flyteorg/flytekit/blob/master/flytekit/core/promise.py#L930 -->
https://github.com/flyteorg/flytekit/blob/master/flytekit/core/promise.py#L1027 -->
https://github.com/flyteorg/flytekit/blob/master/flytekit/core/promise.py#L659-L676
In the last link you get the promise of the remoteEntity and build a Output helper, but you can check how the
>>
is not implemented in this Output helper:https://github.com/flyteorg/flytekit/blob/master/flytekit/core/promise.py#L665-L676
You can workaround this issue doing something like:
But I think it is not expected for the users.
Expected behavior
This should define the upstreams properly to
remote_entity_2
Additional context to reproduce
No response
Screenshots
No response
Are you sure this issue hasn't been raised already?
Have you read the Code of Conduct?
The text was updated successfully, but these errors were encountered: