Add lint-fix make target, add gci to flytectl, remove goimports make target #5484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jason Parraga <[email protected]>
Signed-off-by: Jason Parraga <[email protected]>
Signed-off-by: Jason Parraga <[email protected]>
Sovietaced
changed the title
eapolinario
reviewed
Jun 17, 2024
Signed-off-by: Jason Parraga <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5484 +/- ##
==========================================
- Coverage 61.00% 60.99% -0.02%
==========================================
Files 793 793
Lines 51378 51419 +41
==========================================
+ Hits 31342 31361 +19
- Misses 17149 17166 +17
- Partials 2887 2892 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
robert-ulbrich-mercedes-benz
pushed a commit
to robert-ulbrich-mercedes-benz/flyte
that referenced
this pull request
Jul 2, 2024
…target (flyteorg#5484) * Favor golangci-lint --fix instead running goimports,gci directly Signed-off-by: Jason Parraga <[email protected]> * Enable gci lint on flytectl Signed-off-by: Jason Parraga <[email protected]> * check in gci fixes on flytectl Signed-off-by: Jason Parraga <[email protected]> * Deduplicate per feedback Signed-off-by: Jason Parraga <[email protected]> --------- Signed-off-by: Jason Parraga <[email protected]>
vlibov
pushed a commit
to vlibov/flyte
that referenced
this pull request
Aug 16, 2024
…target (flyteorg#5484) * Favor golangci-lint --fix instead running goimports,gci directly Signed-off-by: Jason Parraga <[email protected]> * Enable gci lint on flytectl Signed-off-by: Jason Parraga <[email protected]> * check in gci fixes on flytectl Signed-off-by: Jason Parraga <[email protected]> * Deduplicate per feedback Signed-off-by: Jason Parraga <[email protected]> --------- Signed-off-by: Jason Parraga <[email protected]> Signed-off-by: Vladyslav Libov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a
lint-fixtarget that will automatically fix linting issues instead of runninggoimports,gci, orgolangci-lintcommands manually.It also adds
gcilinting toflytectl. It appears thatflytectlhadgolangci-lintconfig options forgcibut the linter was not enabled.Lastly, it removes the
goimportsmake target which was pretty error prone. It did not respect thegolangci-lintconfigs in each project and generated dramatically different fixes.