Push flyteidl to pypi and npm on flyteidl/v*.*.*
tags instead of on Flyte releases
#5529
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
https://linear.app/unionai/issue/DX-842/fix-flyteidl-pypi-release
Why are the changes needed?
flyteidl releases to pypi are currently broken since #5419. This is due to the fact that the flyteidl build process expects git tags to be formatted a certain way, but we use the Flyte release tag to kick off the flyteidl push to pypi process.
This causes an issue in CI where we can't find the correct tag to build the flyteidl wheel, e.g. for the 1.13.0-rc0 beta release we saw this error:
Note the incorrect version, we were building a wheel for version
0.1.dev1+gce5eb03
instead of1.13.0-rc0
.What changes were proposed in this pull request?
Similar to how we do with flytectl releases, we can gate the flyteidl-release workflow to happen only when git tags in the format
flyteidl/<new-version>
are pushed to remote. We create those tags as part of publishing a new Flyte release.How was this patch tested?
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link