Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Push flyteidl to pypi and npm on flyteidl/v*.*.* tags instead of on Flyte releases #5529

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

eapolinario
Copy link
Contributor

@eapolinario eapolinario commented Jul 1, 2024

Tracking issue

https://linear.app/unionai/issue/DX-842/fix-flyteidl-pypi-release

Why are the changes needed?

flyteidl releases to pypi are currently broken since #5419. This is due to the fact that the flyteidl build process expects git tags to be formatted a certain way, but we use the Flyte release tag to kick off the flyteidl push to pypi process.

This causes an issue in CI where we can't find the correct tag to build the flyteidl wheel, e.g. for the 1.13.0-rc0 beta release we saw this error:

Successfully built flyteidl-0.1.dev1+gce5eb03.tar.gz and flyteidl-0.1.dev1+gce5eb03-py3-none-any.whl
Uploading distributions to https://upload.pypi.org/legacy/
Uploading flyteidl-0.1.dev1+gce5eb03-py3-none-any.whl
25l
  0% ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 0.0/225.6 kB • --:-- • ?
 36% ━━━━━━━━━━━━━━╸━━━━━━━━━━━━━━━━━━━━━━━━━ 81.9/225.6 kB • 00:01 • 220.7 MB/s
100% ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 225.6/225.6 kB • 00:00 • 4.3 MB/s
100% ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 225.6/225.6 kB • 00:00 • 4.3 MB/s
25hWARNING  Error during upload. Retry with the --verbose option for more details. 
ERROR    HTTPError: 400 Bad Request from https://upload.pypi.org/legacy/        
         The use of local versions in <Version('0.1.dev1+gce5eb03')> is not     
         allowed. See https://packaging.python.org/specifications/core-metadata 
         for more information.       

Note the incorrect version, we were building a wheel for version 0.1.dev1+gce5eb03 instead of 1.13.0-rc0.

What changes were proposed in this pull request?

Similar to how we do with flytectl releases, we can gate the flyteidl-release workflow to happen only when git tags in the format flyteidl/<new-version> are pushed to remote. We create those tags as part of publishing a new Flyte release.

How was this patch tested?

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

Copy link

codecov bot commented Jul 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.98%. Comparing base (5b0d787) to head (179605c).
Report is 116 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5529   +/-   ##
=======================================
  Coverage   60.97%   60.98%           
=======================================
  Files         794      794           
  Lines       51488    51488           
=======================================
+ Hits        31397    31402    +5     
+ Misses      17199    17194    -5     
  Partials     2892     2892           
Flag Coverage Δ
unittests-datacatalog 69.31% <ø> (ø)
unittests-flyteadmin 58.73% <ø> (+0.04%) ⬆️
unittests-flytecopilot 17.79% <ø> (ø)
unittests-flytectl 68.03% <ø> (ø)
unittests-flyteidl 79.04% <ø> (ø)
unittests-flyteplugins 61.85% <ø> (ø)
unittests-flytepropeller 57.29% <ø> (ø)
unittests-flytestdlib 65.57% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eapolinario eapolinario merged commit 9b2a04b into master Jul 1, 2024
50 checks passed
@eapolinario eapolinario deleted the push-flyteidl-to-pypi-and-npm-on-tag branch July 1, 2024 21:21
vlibov pushed a commit to vlibov/flyte that referenced this pull request Aug 16, 2024
… releases (flyteorg#5529)

Signed-off-by: Eduardo Apolinario <[email protected]>
Co-authored-by: Eduardo Apolinario <[email protected]>
Signed-off-by: Vladyslav Libov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants