[flytepropeller] Better handling for task aborts #5566
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
https://flyte-org.slack.com/archives/C06SYN9QJ5N/p1721238762986439
Why are the changes needed?
When a Flyte agent sends the aborted status of a task execution back to Flyte Propeller, it is recorded as a task execution failure instead:
flyte/flyteplugins/go/tasks/plugins/webapi/agent/plugin.go
Lines 275 to 276 in 5b0d787
The Flyte UI ends up showing both the task execution and workflow execution as
FAILED
instead ofABORTED
. This does not seem to align with user expectations.What changes were proposed in this pull request?
This draft PR attempts to address the issue by improving handling of aborted task executions, and marking the task execution and workflow execution as
ABORTED
.We would like to get some feedback on how aborted task executions should be handled and to see if this PR is a step in the right direction.
How was this patch tested?
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link