Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI Feature] Task node overrides are not reflected in flyteconsole #5589

Open
2 tasks done
eapolinario opened this issue Jul 25, 2024 · 1 comment
Open
2 tasks done
Assignees
Labels
enhancement New feature or request ui Admin console user interface

Comments

@eapolinario
Copy link
Contributor

Motivation: Why do you think this is important?

The Task Details tab in flyteconsole is not aware of resource overridden in a task, e.g.:

from flytekit import task, Resources, workflow


@task(
    requests=Resources(
        cpu="2",
        mem="2Gi",
    ),
)
def foo():
    print('task')

@workflow
def my_wf():
    foo()
    foo().with_overrides(
        requests=Resources(
            cpu="1",
            mem="1Gi",
        ),
    )

Notice how in the second execution of foo we override requests.

Currently the Task details view for the second task displays the original requests value.

Goal: What should the final outcome look like, ideally?

The Task Details view should be aware of resource overrides so as not to confuse users, since not having them there gives the false impression that those are not being applied, when in reality they are.

Propose: Link/Inline OR Additional context

The Task Details view for a given task execution should introspect the workflow closure to find which resources are being overridden (if any) and apply that transformation before rendering them.

Are you sure this issue hasn't been raised already?

  • Yes

Have you read the Code of Conduct?

  • Yes
@eapolinario eapolinario added enhancement New feature or request ui Admin console user interface untriaged This issues has not yet been looked at by the Maintainers labels Jul 25, 2024
Copy link

runllm bot commented Jul 25, 2024

Based on Flyte Issue #4543, the Task Details tab in flyteconsole does not currently reflect resource overrides applied using with_overrides. This can lead to confusion as users might think the overrides are not being applied when they actually are.

Would you like more detail on how to address this issue or further explanation on the current behavior and potential fixes?

Sources:


This is an AI-generated response and your feedback is appreciated! Please leave a 👍 if this is helpful and 👎 if it is not.

Mention @RunLLM to ask follow-up questions. See runllm.com for more!

@davidmirror-ops davidmirror-ops removed the untriaged This issues has not yet been looked at by the Maintainers label Aug 1, 2024
@davidmirror-ops davidmirror-ops moved this from Backlog to Assigned in Flyte Issues/PRs maintenance Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ui Admin console user interface
Projects
Status: Assigned
Development

No branches or pull requests

3 participants