Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SecurityContext part 1: applying PodTemplate for InitContainers #5664

Closed
wants to merge 1 commit into from

Conversation

vlibov
Copy link

@vlibov vlibov commented Aug 16, 2024

Tracking issue

Related to #5462

Why are the changes needed?

The Issue #5462 describes the problem in detail.

What changes were proposed in this pull request?

  1. Apply the PodTemplate settings to the InitContainers. In particular, this allows the SecurityContext settings to be applied also to the InitContainer.

How was this patch tested?

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Splits the original PR #5556 into two smaller PRs

Docs link

…y to primary containers)

Signed-off-by: Vladyslav Libov <[email protected]>
Copy link

codecov bot commented Aug 16, 2024

Codecov Report

Attention: Patch coverage is 15.38462% with 11 lines in your changes missing coverage. Please review.

Project coverage is 36.16%. Comparing base (bed761c) to head (59d9e58).
Report is 167 commits behind head on master.

Files with missing lines Patch % Lines
...ns/go/tasks/pluginmachinery/flytek8s/pod_helper.go 15.38% 10 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5664      +/-   ##
==========================================
- Coverage   36.17%   36.16%   -0.01%     
==========================================
  Files        1302     1302              
  Lines      109492   109505      +13     
==========================================
- Hits        39606    39602       -4     
- Misses      65748    65764      +16     
- Partials     4138     4139       +1     
Flag Coverage Δ
unittests-datacatalog 51.37% <ø> (ø)
unittests-flyteadmin 55.29% <ø> (-0.04%) ⬇️
unittests-flytecopilot 12.17% <ø> (ø)
unittests-flytectl 62.28% <ø> (ø)
unittests-flyteidl 7.08% <ø> (ø)
unittests-flyteplugins 53.28% <15.38%> (-0.04%) ⬇️
unittests-flytepropeller 41.74% <ø> (ø)
unittests-flytestdlib 55.35% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@davidmirror-ops davidmirror-ops changed the title SecurtyContext part 1: applying PodTemplate for InitContainers SecurityContext part 1: applying PodTemplate for InitContainers Sep 4, 2024
Copy link
Contributor

@eapolinario eapolinario left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vlibov vlibov closed this Nov 26, 2024
@vlibov
Copy link
Author

vlibov commented Nov 26, 2024

Closed as this was implemented already in PR #5750
#5750

@davidmirror-ops
Copy link
Contributor

Thank you @vlibov!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants