Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core feature] Support specifying workflow labels for the default launch plan in the workflow definition #5774

Closed
2 tasks done
swarup-stripe opened this issue Sep 25, 2024 · 4 comments · Fixed by flyteorg/flytekit#2776
Assignees
Labels
enhancement New feature or request hacktoberfest untriaged This issues has not yet been looked at by the Maintainers

Comments

@swarup-stripe
Copy link

Motivation: Why do you think this is important?

Currently workflow labels/annotations can only be supplied when you launch an execution or when you create a launch plan that's not the default. This creates a big friction point to specifying labels since you have to manually toggle something in the Flyte Console (either to specify the label or switch the launch plan to the one with the label). This will help us add workflow-level metadata and propagate that to all tasks easier.

Goal: What should the final outcome look like, ideally?

Specifying labels directly in the workflow definition like the decorator e.g. @workflow(labels=Labels({"sample-label": "sample-value"}).

Describe alternatives you've considered

We can currently specify it when creating a launch plan but this involves manually switching the launch plan in Flyte Console which is prone to accidents. We can also directly enter in the Flyte Console when launching executions. But again this is prone to accidents. Since the label metadata is semantically tied to the whole workflow not just that particular launch plan, this isn't ideal. We can also leverage pod_template to specify labels to each pod but we'd have to annotate each task in the workflow manually.

Propose: Link/Inline OR Additional context

No response

Are you sure this issue hasn't been raised already?

  • Yes

Have you read the Code of Conduct?

  • Yes
@swarup-stripe swarup-stripe added enhancement New feature or request untriaged This issues has not yet been looked at by the Maintainers labels Sep 25, 2024
@davidmirror-ops
Copy link
Contributor

@Mecoli1219
Copy link
Contributor

#take

@pingsutw
Copy link
Member

pingsutw commented Oct 2, 2024

@swarup-stripe, if we support setting another launch plan as default, would that address your issue? Therefore, you won't need to switch the launch plan in Flyte Console.

you can create a new LP with your labels, and set it as default.

@swarup-stripe
Copy link
Author

Thank you all for the quick turnaround time and for the PR @Mecoli1219!!!

@pingsutw That could technically address it, but ideally we want to enforce having a label and avoid having any unlabelled launch plans so this is definitely the better solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request hacktoberfest untriaged This issues has not yet been looked at by the Maintainers
Projects
Status: Done
5 participants