Remove duplicate recovery interceptor #5870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jason Parraga <[email protected]>
Sovietaced
commented
Oct 19, 2024
| @@ -136,7 +134,6 @@ func newGRPCServer(ctx context.Context, pluginRegistry *plugins.Registry, cfg *c | |||
| ) | |||
|
|
|||
| serverOpts := []grpc.ServerOption{ | |||
| // recovery interceptor should always be first in order to handle any panics in the middleware or server | |||
There was a problem hiding this comment.
unnecessary comment
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5870 +/- ##
==========================================
- Coverage 36.71% 36.71% -0.01%
==========================================
Files 1304 1304
Lines 130081 130079 -2
==========================================
- Hits 47764 47758 -6
- Misses 78147 78151 +4
Partials 4170 4170
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
wild-endeavor
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
While working on an RFC I noticed that there is a duplicate recovery interceptor installed inside the Flyte Admin server. We ideally want to use the custom one which ties into metrics.