Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dependency review gh workflow #5902

Merged
merged 3 commits into from
Oct 23, 2024

Conversation

eapolinario
Copy link
Contributor

@eapolinario eapolinario commented Oct 23, 2024

Why are the changes needed?

We can leverage an integrated github workflow to disallow certain software licenses.

What changes were proposed in this pull request?

Define a new gh workflow using https://github.com/actions/dependency-review-action?tab=readme-ov-file#configuration-options to disallow GPL dependencies.

How was this patch tested?

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

Signed-off-by: Eduardo Apolinario <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
Copy link

codecov bot commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.80%. Comparing base (8890b38) to head (6225ebc).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5902      +/-   ##
==========================================
- Coverage   36.81%   36.80%   -0.01%     
==========================================
  Files        1309     1309              
  Lines      130899   130899              
==========================================
- Hits        48185    48178       -7     
- Misses      78532    78539       +7     
  Partials     4182     4182              
Flag Coverage Δ
unittests-datacatalog 51.58% <ø> (ø)
unittests-flyteadmin 54.01% <ø> (-0.03%) ⬇️
unittests-flytecopilot 11.73% <ø> (ø)
unittests-flytectl 62.40% <ø> (ø)
unittests-flyteidl 6.92% <ø> (ø)
unittests-flyteplugins 53.57% <ø> (ø)
unittests-flytepropeller 43.00% <ø> (ø)
unittests-flytestdlib 55.39% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eapolinario eapolinario enabled auto-merge (squash) October 23, 2024 22:36
@eapolinario eapolinario merged commit 5065f9b into master Oct 23, 2024
49 of 51 checks passed
@eapolinario eapolinario deleted the add-dependency-review-gh-workflow branch October 23, 2024 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants