Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Monorepo] Rename flyteidl #4166

Merged
merged 11 commits into from
Oct 4, 2023
Merged

[Monorepo] Rename flyteidl #4166

merged 11 commits into from
Oct 4, 2023

Conversation

eapolinario
Copy link
Contributor

@eapolinario eapolinario commented Oct 4, 2023 •
edited
Loading

Describe your changes

This PR prepares the terrain for moving flyteidl to the monorepo. List of changes:

  • Rename the go module and all references to flyteidl in the components
  • Similar to how it's done in the other components imported to the monorepo, if we are to let users be able to keep using go get to update flyteidl we need to generate a tag in format flyteidl/vX.Y.Z.

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

@eapolinario
Rename go files and regenerate
2f22ad0 
Signed-off-by: Eduardo Apolinario <[email protected]>
@eapolinario
Fix flyteidl references in flytepropeller
3aadf3f 
Signed-off-by: Eduardo Apolinario <[email protected]>
@eapolinario
Fix flyteidl references in flyteplugins
8713750 
Signed-off-by: Eduardo Apolinario <[email protected]>
@eapolinario
Other flyteidl references
813cede 
Signed-off-by: Eduardo Apolinario <[email protected]>
@eapolinario
Fix flyteidl references in datacatalog
02314fa 
Signed-off-by: Eduardo Apolinario <[email protected]>
@eapolinario
Fix flyteidl references in flyteadmin
5bec96a 
Signed-off-by: Eduardo Apolinario <[email protected]>
@eapolinario
Fix flyteidl references in flytecopilot
ae95f5f 
Signed-off-by: Eduardo Apolinario <[email protected]>
@codecov
Copy link

codecov bot commented Oct 4, 2023 •
edited
Loading

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (d9586b0) 58.98% compared to head (5d7e9a0) 59.31%.
Report is 1 commits behind head on master.

❗ Current head 5d7e9a0 differs from pull request most recent head 7173b4a. Consider uploading reports for the commit 7173b4a to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #4166      +/-   ##
==========================================
+ Coverage   58.98%   59.31%   +0.33%     
==========================================
  Files         619      550      -69     
  Lines       52804    39692   -13112     
==========================================
- Hits        31146    23544    -7602     
+ Misses      19174    13828    -5346     
+ Partials     2484     2320     -164
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...atacatalog/pkg/manager/impl/artifact_data_store.go 68.00% <ø> (+8.00%) ⬆️
datacatalog/pkg/manager/impl/artifact_manager.go 70.23% <ø> (+1.13%) ⬆️
datacatalog/pkg/manager/impl/dataset_manager.go 68.69% <ø> (+2.02%) ⬆️
...atacatalog/pkg/manager/impl/reservation_manager.go 81.30% <ø> (+2.84%) ⬆️
datacatalog/pkg/manager/impl/tag_manager.go 70.21% <ø> (+0.56%) ⬆️
datacatalog/pkg/repositories/gormimpl/artifact.go 84.37% <ø> (+1.44%) ⬆️
datacatalog/pkg/repositories/gormimpl/dataset.go 83.72% <ø> (+0.70%) ⬆️
...tacatalog/pkg/repositories/gormimpl/reservation.go 85.96% <ø> (+2.63%) ⬆️
datacatalog/pkg/repositories/gormimpl/sort.go 100.00% <ø> (ø)
datacatalog/pkg/repositories/gormimpl/tag.go 96.42% <ø> (-0.64%) ⬇️
... and 108 more

... and 443 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eapolinario
goimports -w flytepropeller
9435797 
Signed-off-by: Eduardo Apolinario <[email protected]>
@eapolinario
Run goimports from root
9262f1c 
Signed-off-by: Eduardo Apolinario <[email protected]>
@eapolinario
Emit flyteidl git tag
ed86188 
Signed-off-by: Eduardo Apolinario <[email protected]>
@eapolinario
Fix typo
7173b4a 
Signed-off-by: Eduardo Apolinario <[email protected]>
@eapolinario eapolinario merged commit 97a79c0 into master Oct 4, 2023
40 checks passed
@eapolinario eapolinario deleted the monorepo--rename-flyteidl branch October 4, 2023 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pingsutw pingsutw pingsutw approved these changes

@EngHabu EngHabu EngHabu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eapolinario @EngHabu @pingsutw