docs: update Flyte sandbox configuration and documentation #4729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add instructions for setting up Flyte sandbox in the Kubernetes plugin documentation - Provide example YAML files for configuring Spark in Flyte sandbox - Update the values-override.yaml file for Flyte sandbox configuration Signed-off-by: jason.lai <[email protected]>
dosubot
bot
added
size:L
| metadata: | ||
| name: spark-role | ||
| namespace: "{{ namespace }}" | ||
| rules: |
There was a problem hiding this comment.
One of the tests is complaining about a list being out of range. Not sure if it's a matter of indentation.
Also, this is the Role I've been using with flyte-core on EKS:
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4729 +/- ##
==========================================
+ Coverage 58.33% 58.53% +0.20%
==========================================
Files 626 625 -1
Lines 53938 53669 -269
==========================================
- Hits 31465 31417 -48
+ Misses 19949 19737 -212
+ Partials 2524 2515 -9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
- Change the link to the `flyte-sandbox Helm chart` in the documentation Signed-off-by: jason.lai <[email protected]>
Signed-off-by: Future-Outlier <[email protected]>
Signed-off-by: Future-Outlier <[email protected]>
Signed-off-by: Future-Outlier <[email protected]>
Signed-off-by: Future-Outlier <[email protected]>
- Added a new section for spinning up a cluster - Added a new tab for Flyte sandbox in the documentation Signed-off-by: jason.lai <[email protected]>
…asonlai1218/flyte into enhance-spark-on-flyte-sandbox
Co-authored-by: Samhita Alla <[email protected]> Signed-off-by: David Espejo <[email protected]>
davidmirror-ops
approved these changes
Jan 25, 2024
Future-Outlier
approved these changes
Jan 26, 2024
|
@jasonlai1218 Thanks so much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
Why are the changes needed?
Currently, official documentation does not provide instructions on how to use Helm to deploy Flyte sandbox on a Kubernetes cluster and configure the Spark plugin.
What changes were proposed in this pull request?
kubectl get pods -n --all-namespacestokubectl get pods -n <namespace>.How was this patch tested?
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link